Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging the ky-universal broke the builds. Should we bump ky and node versions? #572

Closed
onnimonni opened this issue Oct 31, 2024 · 1 comment
Closed

Merging the ky-universal broke the builds. Should we bump ky and node versions? #572

onnimonni opened this issue Oct 31, 2024 · 1 comment

Comments

@onnimonni
Copy link
Contributor

@transitive-bullshit after merging the #394 the newly added import 'ky-universal' breaks builds: https://github.com/NotionX/react-notion-x/actions/runs/11605079223/job/32314865994#step:5:46

I guess it would be easier to try instead to use ky 1.0.0 where ky-universal is not needed anymore.

It would mean that we need to bump the minimum supported node version to >=18 which supports native fetch.
onnimonni added a commit to onnimonni/react-notion-x that referenced this issue Oct 31, 2024
@onnimonni
Update ky to 0.3->1.0, node 16->18 and add tsimp TS loader
8f7f7a8 
After replacing got package with ky the builds started to fail. This fixes NotionX#572
@transitive-bullshit
Copy link
Member

Fixed by #571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@transitive-bullshit @onnimonni