Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad Thumbnail returns an error #37

Open
Dittofate opened this issue Jun 18, 2021 · 5 comments
Open

iPad Thumbnail returns an error #37

Dittofate opened this issue Jun 18, 2021 · 5 comments

Comments

@Dittofate
Copy link

Can you add support for iPad version save files. When trying to load the save file, it returns an error because of the thumbnail.
The thumbnail size for IPad seems to be 480x270.
When the same save file is loaded onto a pc version and resaved it works fine loading the pc save file.
DE57C942-8E2E-4724-90B9-AD28B95D7FC9

@NovFR
Copy link
Owner

NovFR commented Jun 18, 2021

This is a problem with archive extraction, I have little control to this process since it is entirely done by LS Lib

Can you send me the iPad save file ?

@Dittofate
Copy link
Author

This is a problem with archive extraction, I have little control to this process since it is entirely done by LS Lib

Can you send me the iPad save file ?

Here’s a link - https://drive.google.com/drive/folders/1uSOcTTMUykrHq9F0jtrLn9xvw_fPNGdB

I forgot to mention that the save file is pulled from iCloud instead of the local storage, because unless it’s a jailbroken iPad normal users don’t have access to the local files.
Is it possible that iCloud puts a compression on the thumbnail and that’s the reason the save editor can’t load it directly? Just shooting in the dark, but maybe a solution would be a patcher for instance so no matter if it was an original thumbnail or not, the save edition may load the thumbnail correctly by making the thumbnail file match the expected one or ignore it all together?

@NovFR
Copy link
Owner

NovFR commented Jun 19, 2021

The editor only loads the thumbnail on file selection and when it displays informations about a savegame. Otherwise, it is completely ignored. And it only uses the thumbnail inside the LSV archive, not the "external" PNG file.

If the archive integrity is fine, the program will load the save file. In your first message, it seems there is a CRC error meaning something is wrong in the archive. And I don't know what because the file you gave me is loaded fine on my computer.

@Dittofate
Copy link
Author

My bad, I’ve sent you an already overwritten file on pc. Can you try this one just downloaded from iCloud - https://drive.google.com/drive/folders/10zPOCZk7GXSKmv7HOzts2drdvA2fbuvY

@NovFR
Copy link
Owner

NovFR commented Jun 23, 2021

It looks like the iPad version uses a different CRC. If I bypass the CRC checks, the meta.lsf seems to be loaded fine (the information of the team is missing but that's not necessarily a problem) Unfortunately, I can't bypass the CRC checks of LSLib, so I can't make further tests.

There is an open issue in LSLib about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants