Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torrent table row header not always aligned with column #2794

Closed
4 tasks done
koblack opened this issue Nov 14, 2024 · 4 comments · Fixed by #2860
Closed
4 tasks done

Torrent table row header not always aligned with column #2794

koblack opened this issue Nov 14, 2024 · 4 comments · Fixed by #2860
Labels
bug v5.2

Comments

@koblack
Copy link
Contributor

koblack commented Nov 14, 2024

Please complete the following tasks.

  • Web browser cache cleared
  • Link provided to install script if applicable
  • Not using broken rtinst install script
  • Web browser, ruTorrent, PHP and OS version provided

Tell us about your environment

Web Browser: Google Chrome 130.0.6723.117
ruTorrent: master: c6caa69
PHP: PHP 7.4.3
OS: Ubuntu 20.04.6 LTS
web server: lighttpd/1.4.55

Tell us how you installed ruTorrent

git clone https://github.com/Novik/ruTorrent

Describe the bug

When we scroll the torrent table all the way to the right, the header row is not aligned with the column.

ezgif-2-e051a7cb57

Steps to reproduce

Scroll the torrent table all the way to the right.

Expected behavior

The header row is aligned with the column.

Additional context

No response
@stickz
Copy link
Collaborator

stickz commented Nov 17, 2024

@jevenski once this is fixed, we can post Beta 5. And possibly the stable v5.1 release!

@jevenski
Copy link
Contributor

jevenski commented Nov 18, 2024 •
edited
Loading

This issue existed before v5, and is because of the internal structure of s-tables. The table header and the table body belong to two separate HTML tables. I'm afraid this won't be easily fixed in with one line or two.

@koblack
Copy link
Contributor Author

koblack commented Nov 18, 2024

Thanks for checking this. Let's leave it as is for now and move forward.

@stickz
Copy link
Collaborator

stickz commented Nov 18, 2024

Alright, target adjusted for v5.2. ruTorrent v5.1 Beta 5 released. https://github.com/Novik/ruTorrent/releases/tag/v5.1-beta5

jevenski added a commit to jevenski/ruTorrent that referenced this issue Jan 21, 2025
@jevenski
Merge stable head and body into one table
26a1fd4 
- Merge stable-head and stable-body into one HTML table, and thus
  removes the process to sync horizontal scroll position.
- Fix table header split away from table body when scrolled to right
  end (Novik#2794).
- Adjust internal styles of the s-table to fit the new table structure.
@jevenski jevenski mentioned this issue Jan 21, 2025
Merged
@stickz stickz linked a pull request Jan 26, 2025 that will close this issue
Merge stable head and body into one table #2860
Merged
stickz pushed a commit that referenced this issue Jan 26, 2025
@jevenski
Merge stable head and body into one table (#2860)
8eb76bc 
* Merge stable head and body into one table

- Merge stable-head and stable-body into one HTML table, and thus
  removes the process to sync horizontal scroll position.
- Fix table header split away from table body when scrolled to right
  end (#2794).
- Adjust internal styles of the s-table to fit the new table structure.

* Fix various bugs

- Fix move header display postion error.
- Fix table sorting on mobile screens.
- Fix tracker icon display issue
  (#2849).
@koblack koblack closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v5.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge stable head and body into one table jevenski/ruTorrent
3 participants
@stickz @koblack @jevenski