Seperate icons from background on panel heading #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously on the headings of the side panel, open/close icons were defined using the heading background image, which also contains the actual background images for some themes like MaterialDesign and Oblivion. In this patch, the icons are extracted from the background of headings and implemented using the `::before` pseudo-elements. This seperates the icons from the heading background images, thus allowing defining heading background using CSS gradient without affecting the icons. - Dedupe some panel background images in MaterialDesign and Oblivion. - Fix Oblivion panel heading background width limitation. The new CSS gradient implementation can grow infinitely.
|
Looks good! A few screenshots from me:
|
|
Thanks for the help testing this @koblack. I'm now able to merge this right away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue of the heading background of the side panel in Oblivion theme. But under the hood, the change is not limited to the Oblivion theme. The fundamental structure of the headings were altered a bit, for ease of maintenance in the future.
::beforepseudo-elements. This seperates the icons from the heading background images, thus allowing defining heading background using CSS gradient without affecting the icons.