Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Sodium Item Renderer optimization #52

Closed
Aeltumn opened this issue Apr 7, 2024 · 1 comment
Closed

Upstream Sodium Item Renderer optimization #52

Aeltumn opened this issue Apr 7, 2024 · 1 comment
Labels
enhancement New feature or request priority: medium For tasks that should be addressed eventually.

Comments

@Aeltumn
Copy link
Member

Aeltumn commented Apr 7, 2024

Noxesium has a wrapper around Sodium's ItemColor where we add a cache on color lookups. This improves performance on complicated models like the ones MCC Island uses where multiple different quads have the same tint index. These changes should be upstreamed into Sodium 0.6 instead of mixing in on Noxesium's side.

The other mixin for video settings changes should eventually become an API on Sodium's side and the mixin for beacon rendering is relatively minor and unimportant (also not a good upstream).

Relevant:
https://github.com/Noxcrew/noxesium/blob/version/v1.3/fabric/src/main/java/com/noxcrew/noxesium/feature/model/ItemColorWrapper.java

@Aeltumn Aeltumn added the enhancement New feature or request label Apr 7, 2024
@Aeltumn Aeltumn added this to the 1.3 milestone Apr 7, 2024
@Aeltumn Aeltumn added the priority: medium For tasks that should be addressed eventually. label Apr 7, 2024
@Aeltumn Aeltumn removed this from the 2.0 milestone Apr 12, 2024
@Aeltumn
Copy link
Member Author

Aeltumn commented Jul 14, 2024

After testing this out the optimization was found to be largely obsolete and not worth the effort.

@Aeltumn Aeltumn closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium For tasks that should be addressed eventually.
Development

No branches or pull requests

1 participant