Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention existence of Central Package Management on page for NU1604 #13500

Open
Cliabhach opened this issue Sep 13, 2022 · 3 comments · May be fixed by NuGet/docs.microsoft.com-nuget#3320
Open
Assignees
Labels
Area:RestoreCPM Central package management good first issue Issues identified as good for first-time contributors hacktoberfest Priority:1 High priority issues that must be resolved in the current sprint. Type:Docs

Comments

@Cliabhach
Copy link

This is mainly a documentation request - happy to refile if this needs to be reported somewhere different.

I am using dotnet 6.0.400 on Linux.

Background

I have a small multi-project solution. All of the projects in this solution use CPM to manage dependency versions. Since the dotnet commands and templates do not use that feature by default, I chose (perhaps poorly) to edit the Directory.Packages.props manually through VS Code whenever dependency versions need to change.

This particular issue

I wrote invalid XML in my Directory.Packages.props - specifically, an unclosed tag. This caused subsequent calls to dotnet restore to fail. One error message appears for each dependency, in a form like so:

MyProject.csproj : warning NU1604: Project dependency Microsoft.EntityFrameworkCore.SqlServer does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results.

If dotnet restore is called with detailed- or diagnostic-level verbosity, I note the following in the output:

Project "/path/to/solution/Directory.Packages.props" was not imported by "/path/to/dotnet/sdk/6.0.400/NuGet.props" at (35,3), due to the file being invalid.

My request

Looking at the official docs for NU1604, I noticed no reference to CPM. Please provide some kind of link, and (if it's not too much trouble) suggest that there might be this kind of situation with a malformed file.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@JonDouglas JonDouglas added hacktoberfest good first issue Issues identified as good for first-time contributors labels Sep 28, 2022
Copy link

Thanks for sharing your feedback. We apologize for our delayed response. Due to the sheer volume of feedback in our repo, we have decided to prioritize the newest issues and are automatically closing our oldest issues with an Issues bot. If you believe your feedback is still actionable, then either respond directly in this issue or open a new documentation issue and we’ll review. If no activity occurs in the next 14 days, this issue will be closed.

@Cliabhach
Copy link
Author

I mean...the NuGet NU1604 docs don't seem to have been updated. This is still an issue.

@nkolev92 nkolev92 added the Priority:1 High priority issues that must be resolved in the current sprint. label Jun 1, 2024
@nkolev92 nkolev92 transferred this issue from NuGet/docs.microsoft.com-nuget Jun 1, 2024
@nkolev92 nkolev92 added Area:RestoreCPM Central package management and removed Area:CentralPackageManagement CPM labels Jun 1, 2024
Copy link
Contributor

Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot added the missing-required-type The required type label is missing. label Jun 2, 2024
@zivkan zivkan added Type:Docs and removed missing-required-type The required type label is missing. labels Jun 2, 2024
@martinrrm martinrrm self-assigned this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:RestoreCPM Central package management good first issue Issues identified as good for first-time contributors hacktoberfest Priority:1 High priority issues that must be resolved in the current sprint. Type:Docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants