[15.0][FIX] account_financial_report: keyError on fin_bal_currency_id

[TheerayutEncoder]

keyError: 'fin_bal_currency_id

So I use get() method for skip this error if there is no fin_bal_currency_id key on dict object.

  File "/opt/odoo/auto/addons/report_xlsx/controllers/main.py", line 77, in report_download
    response = self.report_routes(
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 546, in response_wrap
    response = f(*args, **kw)
  File "/opt/odoo/auto/addons/report_xlsx_helper/controllers/main.py", line 50, in report_routes
    return super().report_routes(reportname, docids, converter, **data)
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 546, in response_wrap
    response = f(*args, **kw)
  File "/opt/odoo/auto/addons/report_xlsx/controllers/main.py", line 37, in report_routes
    xlsx = report.with_context(**context)._render_xlsx(docids, data=data)[0]
  File "/opt/odoo/auto/addons/account_financial_report/models/ir_actions_report.py", line 25, in _render_xlsx
    return super(IrActionsReport, obj)._render_xlsx(docids, data)
  File "/opt/odoo/auto/addons/report_xlsx_helper/models/ir_actions_report.py", line 19, in _render_xlsx
    return super()._render_xlsx(docids, data)
  File "/opt/odoo/auto/addons/report_xlsx/models/ir_report.py", line 22, in _render_xlsx
    report_model.with_context(active_model=self.model)
  File "/opt/odoo/auto/addons/report_xlsx/report/report_abstract_xlsx.py", line 105, in create_xlsx_report
    self.generate_xlsx_report(workbook, data, objs)
  File "/opt/odoo/auto/addons/account_financial_report/report/abstract_report_xlsx.py", line 40, in generate_xlsx_report
    self._generate_report_content(workbook, objects, data, report_data)
  File "/opt/odoo/auto/addons/account_financial_report/report/general_ledger_xlsx.py", line 350, in _generate_report_content
    if foreign_currency and account["fin_bal_currency_id"]:
KeyError: 'fin_bal_currency_id'```

[pedrobaeza]

This was fixed in #1256. Have you tried with that update code?

[TheerayutEncoder]

This was fixed in #1256. Have you tried with that update code?

Yes, my code is updated but it still got an error when it check on line 350
with this condition if foreign_currency and account["fin_bal_currency_id"]:

[pedrobaeza]

Your commit history seems incorrect.

[yajo]

I'm getting a similar error in v16, but the fix I think won't match.

[yajo]

See #1260 for the v16 fix.

[TheerayutEncoder]

@yajo I'm not sure, is it about this PR #1255
I'm forget about this issue, I just re open this PR (my team fix this)

[TheerayutEncoder]

Your commit history seems incorrect.

I just realize this is my mistake, actually I dont pretend to edit on file xml and it come from this PR #1255
Should I squash all of this commit into 1 commit?

I need your suggestions.
Thanks in advance.

[pedrobaeza]

@victoralmau can you check?

[victoralmau]

Fixed #1262