[MIG] account_move_exception: Migration to 18.0

Author: huynh-ch

account_move_exception/README.rst

@@ -72,6 +72,9 @@ Contributors
 
 - Miquel Raïch <[email protected]>
 - Pimolnat Suntian <[email protected]>
+- `Komit <https://komit-consulting.com>`__:
+
+  - Cai Hoang Huynh
 
 Maintainers
 -----------

account_move_exception/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Account Move Exception",
     "summary": "Custom exceptions on account move",
-    "version": "15.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Generic Modules/Account",
     "author": "ForgeFlow, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/account-invoicing",

account_move_exception/data/account_exception_data.xml

@@ -9,8 +9,6 @@
         <field name="user_id" ref="base.user_root" />
         <field name="interval_number">20</field>
         <field name="interval_type">minutes</field>
-        <field name="numbercall">-1</field>
-        <field name="doall" eval="False" />
         <field name="active" eval="False" />
     </record>
     <record id="am_excep_no_email" model="exception.rule">

account_move_exception/init_hook.py

@@ -9,12 +9,12 @@
 logger = logging.getLogger(__name__)
 
 
-def pre_init_hook(cr):
+def pre_init_hook(env):
     """
     The objective of this hook is to speed up the installation
     of the module on an existing Odoo instance.
     """
-    store_exception_fields(cr)
+    store_exception_fields(env.cr)
 
 
 def store_exception_fields(cr):

account_move_exception/models/account_move.py

@@ -31,7 +31,7 @@ def account_move_check_exception(self):
         if moves:
             moves._check_exception()
 
-    @api.onchange("line_ids")
+    @api.onchange("invoice_line_ids")
     def onchange_ignore_exception(self):
         if self.state == "posted":
             self.ignore_exception = False

account_move_exception/readme/CONTRIBUTORS.md

@@ -1,2 +1,4 @@
 - Miquel Raïch \<[email protected]\>
 - Pimolnat Suntian \<[email protected]\>
+- [Komit](https://komit-consulting.com):
+  - Cai Hoang Huynh

account_move_exception/static/description/index.html

@@ -414,6 +414,10 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <ul class="simple">
 <li>Miquel Raïch &lt;<a class="reference external" href="mailto:miquel.raich&#64;forgeflow.com">miquel.raich&#64;forgeflow.com</a>&gt;</li>
 <li>Pimolnat Suntian &lt;<a class="reference external" href="mailto:pimolnats&#64;ecosoft.co.th">pimolnats&#64;ecosoft.co.th</a>&gt;</li>
+<li><a class="reference external" href="https://komit-consulting.com">Komit</a>:<ul>
+<li>Cai Hoang Huynh</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

account_move_exception/tests/test_account_exception.py

@@ -16,16 +16,7 @@ def setUp(self):
         self.product_id_1 = self.env.ref("product.product_product_6")
         self.product_id_2 = self.env.ref("product.product_product_7")
         self.product_id_3 = self.env.ref("product.product_product_7")
-        self.account_receivable = self.env["account.account"].search(
-            [
-                (
-                    "user_type_id",
-                    "=",
-                    self.env.ref("account.data_account_type_receivable").id,
-                )
-            ],
-            limit=1,
-        )
+
         self.account_exception_confirm = self.env["account.exception.confirm"]
         self.exception_noemail = self.env.ref(
             "account_move_exception.am_excep_no_email"
@@ -78,20 +69,23 @@ def test_account_move_exception(self):
         # Add an account move to test after AM is confirmed
         # set ignore_exception = False  (Done by onchange of line_ids)
         field_onchange = self.AccountMove._onchange_spec()
-        self.assertEqual(field_onchange.get("line_ids"), "1")
+        self.assertEqual(field_onchange.get("invoice_line_ids"), "1")
         self.env.cache.invalidate()
         self.am3New = self.AccountMove.new(self.am_vals.copy())
         self.am3New.ignore_exception = True
         self.am3New.state = "posted"
         self.am3New.onchange_ignore_exception()
         self.assertFalse(self.am3New.ignore_exception)
-        self.am.line_ids.write(
-            {
-                "product_id": self.product_id_3.id,
-                "quantity": 2,
-                "price_unit": 30,
-            }
-        )
+        self.env.cache.clear()
+
+        # this cannot be done on a posted invoice in 17.0
+        # self.am.line_ids.write(
+        #     {
+        #         "product_id": self.product_id_3.id,
+        #         "quantity": 2,
+        #         "price_unit": 30,
+        #     }
+        # )
 
         # Set ignore exception True  (Done manually by user)
         self.am.ignore_exception = True
@@ -102,6 +96,11 @@ def test_account_move_exception(self):
         self.am.action_post()
         self.assertTrue(self.am.state, "posted")
 
+        # avoid balance check:(fails because Record does not exist or has been deleted.)
+        # for line in self.am.line_ids:
+        #     line.price_unit = 0.0
+        #     line.credit = 0.0
+
         # Simulation the opening of the wizard account_exception_confirm and
         # set ignore_exception to True
         am_except_confirm = self.account_exception_confirm.with_context(
@@ -112,9 +111,5 @@ def test_account_move_exception(self):
             }
         ).create({"ignore": True})
 
-        # avoid balance check:
-        for line in self.am.line_ids:
-            line.credit = 0.0
-
         am_except_confirm.action_confirm()
         self.assertTrue(self.am.ignore_exception)

account_move_exception/views/account_view.xml

@@ -3,8 +3,8 @@
     <record id="action_account_test_tree" model="ir.actions.act_window">
         <field name="name">Account Exception Rules</field>
         <field name="res_model">exception.rule</field>
-        <field name="view_mode">tree,form</field>
-        <field name="view_id" ref="base_exception.view_exception_rule_tree" />
+        <field name="view_mode">list,form</field>
+        <field name="view_id" ref="base_exception.view_exception_rule_list" />
         <field
             name="domain"
         >[('model', 'in', ['account.move', 'account.move.line'])]</field>
@@ -34,7 +34,7 @@
                     class="alert alert-danger alert-dismissable"
                     role="alert"
                     style="margin-bottom:0px;"
-                    attrs="{'invisible':[('exceptions_summary','=', False)]}"
+                    invisible="not exceptions_summary"
                 >
                     <strong>You have an outstanding exception to manage:</strong>
                     <field name="exceptions_summary" />
@@ -51,14 +51,14 @@
             <xpath expr="//group/group[@id='header_right_group']" position="inside">
                 <field
                     name="ignore_exception"
-                    states="draft"
+                    invisible="state != 'draft'"
                     groups="base_exception.group_exception_rule_manager"
                 />
                 <field
                     name="exception_ids"
                     widget="many2many_tags"
                     readonly="True"
-                    attrs="{'invisible': [('exception_ids', '=', [])]}"
+                    invisible="not exception_ids"
                 />
             </xpath>
         </field>