Migration to version 18.0

[OCA-git-bot]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

• account_banking_mandate
• account_banking_mandate_contact
• account_banking_mandate_sale
• account_banking_mandate_sale_contact
• account_banking_pain_base
• account_banking_sepa_credit_transfer
• account_banking_sepa_direct_debit
• account_payment_mode
• account_payment_order
• account_payment_order_grouped_output
• account_payment_order_notification
• account_payment_partner
• account_payment_purchase
• account_payment_purchase_stock
• account_payment_sale
• account_vendor_bank_account_default
• account_vendor_bank_account_default_purchase

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

[BertVGroenendael]

[18.0][MIG] account_payment_mode

[alexis-via]

We need to take some important decisions before we start the migration to v18. One of the big decision is about the introduction of the notion of payment mode in the "account" module via this commit:
odoo/odoo@cdd1596#diff-a13b3dfd8d9e1c45eee3b202345ad950f6b90db975708ee34b9bff2886f4513d
It seems that Odoo nows considers account.payment.method.line as OCA's account.payment.mode. They added 2 M2O company-dependent fields on res.partner for "Customer Payment Mode" and "Supplier Payment Mode". They added the M2O on account.move. Just like OCA's account.payment.mode, account.payment.method.line has a M2O to account.payment.method. You can have a look at the fields on account.payment.method.line
https://github.com/odoo/odoo/blob/18.0/addons/account/models/account_payment_method.py#L96
One thing that may be annoying for us: the company_id field is a related of journal_id.company_id. But we could probably change that to have a regular company_id field and replace our field fixed_journal_id by the native field journal_id (and we would keep our field variable_journal_ids which is essential of course).

If we decide to use account.payment.method.line as a replacement of account.payment.mode, it implies that the separation between account_payment_mode and account_payment_partner doesn't make sense any more. And of course, the module name account_payment_mode would not make real sense any more. I see 2 options:

1. drop module account_payment_mode and keep account_payment_partner (the code of this module would be fully re-organized of course)
2. replace the 2 modules account_payment_mode and account_payment_partner by a new module with a new name. My idea for the name of this new module would be account_payment_base or account_payment_base_oca.

I also noticed that Odoo dropped account_journal_payment_debit_account_id and account_journal_payment_credit_account_id on res.company. They removed those fields in this commit "[IMP] account: make journal entry optional for payments"
odoo/odoo@01b87f1#diff-d6f92fa76f12db6dc10ae7fe3fd7f719cc110daa5a0d64c451b10e1b25ebbcadL104
BTW, should we adopt the "no journal entry for account.payment" for account.payments generated by a payment order ?

[johnny-longneck]

@alexis-via I would welcome the effort to homogenize the payment mode module with new standard logic.

[florian-dacosta]

Thanks for raising this subject.
I think we should switch to account.payment.method.line as well even if it is probably more work on the short-term, and we can't be sure how it will evolve in future version...

About the module replacing account_payment_mode and account_payment_partner, I would prefer to have account_payment_base_oca because what will be added may not have anything to do with the partners?

And for the final question about the "no journal entry for account.payment"... I would say we should follow, unless we have strong arguments for not doing it?
I don't fill we would really loose functionalities since the "in payment" state will still work.

[pedrobaeza]

Notes for me meanwhile I inspect deeper: Related Odoo patch: odoo/odoo#182390

[Kimkhoi3010]

[18.0][MIG] account_invoice_select_for_payment

[alexis-via]

I wish I had more answers on my proposals... Let's go with a new module "account_payment_base_oca" to replace account_payment_mode and account_payment_partner !

[pedrobaeza]

Please wait till Thursday and I'll answer

[pedrobaeza]

I have sped up the checking of this for having an answer ASAP.

About replacing account.payment.mode with account.payment.method.line, for me is a total no. This model doesn't reflect the real need of users, which is to annotate the payment instrument. Instead, they put a field where you see several times the same payment method, one per journal:

You may know that you want SEPA CT, but not yet with which bank (or yes, but not defined at partner level). For me it's totally misleading, and users will complain with the change.

And what happen if you change your bank account? You are forced to change this data in all your partners. It's a nonsense.

We should keep account_payment_mode, and hide in this one those infamous m2o fields.

About the entry creation on payments, I already pointed to odoo/odoo#182390, which is forcing to create them in community (not having the enterprise accounting module installed), which is an ugly patch, but it serves to us. I think there's nothing to do, except declare account_payment_order as incompatible with account_accountant (enterprise module - I think this is its name -).

[JordiMForgeFlow]

@pedrobaeza I agree with you on keeping account_payment_mode. However, why should account_payment_order be incompatible with enterprise? If journal entry creation is optional in enterprise, couldn't we ensure that it is required when using account_payment_order?

[pedrobaeza]

@JordiMForgeFlow if you think it's possible to compatibilize them, go ahead, but I think it should be done on a glue module, for not having the maintenance burden in the base module for something that can't be checked in tests.