[FIX] fieldservice: Fixed expected singleton on mass edit

Author: BernatObrador

fieldservice/models/fsm_order.py

@@ -260,13 +260,14 @@ def create(self, vals):
     is_button = fields.Boolean(default=False)
 
     def write(self, vals):
-        if vals.get("stage_id", False) and vals.get("is_button", False):
-            vals["is_button"] = False
-        else:
-            stage_id = self.env["fsm.stage"].browse(vals.get("stage_id"))
-            if stage_id == self.env.ref("fieldservice.fsm_stage_completed"):
-                raise UserError(_("Cannot move to completed from Kanban"))
-        self._calc_scheduled_dates(vals)
+        for record in self:
+            if vals.get("stage_id", False) and vals.get("is_button", False):
+                vals["is_button"] = False
+            else:
+                stage_id = self.env["fsm.stage"].browse(vals.get("stage_id"))
+                if stage_id == self.env.ref("fieldservice.fsm_stage_completed"):
+                    raise UserError(_("Cannot move to completed from Kanban"))
+            record._calc_scheduled_dates(vals)
         res = super().write(vals)
         return res
 

fieldservice/tests/test_fsm_order.py

@@ -256,15 +256,15 @@ def test_fsm_order(self):
             )
         )
         self.assertTrue(data, "It should be able to read group")
-        self.Order.write(
+        self.order.write(
             {
                 "location_id": self.test_location.id,
                 "stage_id": self.stage1.id,
                 "is_button": True,
             }
         )
         with self.assertRaises(UserError):
-            self.Order.write(
+            self.order.write(
                 {
                     "location_id": self.test_location.id,
                     "stage_id": self.stage1.id,