Skip to content

Commit eec57ba

Browse files
author
TB-Ph35
committed
FIX comments and '_'
1 parent 6515191 commit eec57ba

File tree

3 files changed

+11
-39
lines changed

3 files changed

+11
-39
lines changed

fieldservice_survey/controllers/main.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright 2023 - TODAY, Marcel Savegnago <[email protected]>
22
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
33

4-
from odoo import _, http
4+
from odoo import http
55
from odoo.exceptions import AccessDenied
66
from odoo.http import request
77
from odoo.osv import expression
@@ -26,7 +26,7 @@ def _get_user_input_domain(self, survey, line_filter_domain, **post):
2626
try:
2727
fsm_order = request.env["fsm.order"].sudo().browse(int(fsm_order_id))
2828
except ValueError:
29-
raise AccessDenied(_("Invalid FSM Order ID")) from None
29+
raise AccessDenied(request.env._("Invalid FSM Order ID")) from None
3030

3131
user = request.env.user
3232
partner = user.partner_id
@@ -46,7 +46,9 @@ def _get_user_input_domain(self, survey, line_filter_domain, **post):
4646
user_input_domain,
4747
)
4848

49-
raise AccessDenied(_("You do not have access to this FSM Order Survey"))
49+
raise AccessDenied(
50+
request.env._("You do not have access to this FSM Order Survey")
51+
)
5052

5153
@http.route(
5254
"/fsm_order/<int:fsm_order_id>/results", type="http", auth="user", website=True
@@ -55,7 +57,7 @@ def survey_results(self, fsm_order_id, **post):
5557
try:
5658
fsm_order = request.env["fsm.order"].sudo().browse(fsm_order_id)
5759
except ValueError:
58-
raise AccessDenied(_("Invalid FSM Order ID")) from None
60+
raise AccessDenied(request.env._("Invalid FSM Order ID")) from None
5961

6062
if (
6163
fsm_order.person_id.partner_id == request.env.user.partner_id
@@ -105,7 +107,7 @@ def survey_results(self, fsm_order_id, **post):
105107
survey_sudo = answer.survey_id
106108

107109
if not survey_sudo:
108-
raise AccessDenied(_("No survey found for the given FSM Order"))
110+
raise AccessDenied(request.env._("No survey found for the given FSM Order"))
109111

110112
post["fsm_order_id"] = fsm_order_id
111113
user_input_lines_sudo, search_filters = self._extract_filters_data(

fieldservice_survey/views/res_config_settings.xml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -19,37 +19,7 @@
1919
name="fsm_order_survey_template_id"
2020
invisible="module_fieldservice_survey == False"
2121
/>
22-
<!-- widget="many2many_tags" /> -->
2322
</setting>
24-
<!-- <div -->
25-
<!-- name="module_fieldservice_survey" -->
26-
<!-- class="col-xs-12 col-md-6 o_setting_box" -->
27-
<!-- > -->
28-
<!-- <div class="o_setting_left_pane"> -->
29-
<!-- <field name="module_fieldservice_survey" /> -->
30-
<!-- </div> -->
31-
<!-- <div class="o_setting_right_pane"> -->
32-
<!-- <label -->
33-
<!-- for="module_fieldservice_survey" -->
34-
<!-- string="Enable feedback request through surveys" -->
35-
<!-- /> -->
36-
<!-- <div class="text-muted"> -->
37-
<!-- Enable feedback request through surveys -->
38-
<!-- </div> -->
39-
<!-- <div -->
40-
<!-- class="content-group" -->
41-
<!-- invisible="module_fieldservice_survey == False" -->
42-
<!-- > -->
43-
<!-- <div class="row mt16"> -->
44-
<!-- <label -->
45-
<!-- for="fsm_order_survey_template_id" -->
46-
<!-- class="col-lg-3 o_light_label" -->
47-
<!-- /> -->
48-
<!-- <field name="fsm_order_survey_template_id" /> -->
49-
<!-- </div> -->
50-
<!-- </div> -->
51-
<!-- </div> -->
52-
<!-- </div> -->
5323
</xpath>
5424
</field>
5525
</record>

fieldservice_survey/wizard/fsm_order_survey_submit.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from dateutil.relativedelta import relativedelta
44

5-
from odoo import _, api, fields, models
5+
from odoo import api, fields, models
66
from odoo.exceptions import UserError
77

88
_logger = logging.getLogger(__name__)
@@ -83,7 +83,7 @@ def default_get(self, fields_list):
8383
"""Override default_get to add custom defaults."""
8484
if not self.env.user.email:
8585
raise UserError(
86-
_(
86+
self.env._(
8787
"Unable to post message,"
8888
"please configure the sender's email address."
8989
)
@@ -236,8 +236,8 @@ def action_send(self):
236236
).activity_schedule(
237237
"mail.mail_activity_data_todo",
238238
self.deadline,
239-
summary=_("Fill the answer form on survey"),
240-
note=_(
239+
summary=self.env_("Fill the answer form on survey"),
240+
note=self.env._(
241241
"An survey was requested. Please take time to fill "
242242
'the <a href="%s" target="_blank">survey</a>'
243243
)

0 commit comments

Comments
 (0)