[17.0][ADD] fieldservice_base_location: New module fieldservice_base_location

[BernatObrador]

This module adds the zip_id field to the fsm.location form, enabling automatic address completion based on the ZIP code entered in the location’s completion field.

To use the module, follow these steps:

1. Go to Contacts → Configuration → ZIPs.

2. Create a new ZIP entry.

3. Navigate to Field Service → Master Data → Locations.

Select an existing location or create a new one.

In the address section, you’ll now see the ZIP code autocomplete field.
Simply enter the ZIP code, and the system will automatically fill in all related address fields.

cc https://github.com/APSL 7083

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

[ppyczko]

LGTM, code review and tested in runboat!

[peluko00]

LGTM, code review and tested in runboat

[lbarry-apsl]

Code and runboat reviewed, LGTM!

[mpascuall]

LGTM!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[ivantodorovich]

IMO this module should be named fieldservice_base_location or fieldservice_partner_location, and be auto-installed when base_location is installed

[ivantodorovich]

You don't need a write override, since fsm.location inherits from res.partner the city_id, state_id, country_id etc are already computed whenever zip_id changes..

I think the only thing this module needs to do is to add the field to the view, similarly to how base_location is doing for the partner: https://github.com/OCA/partner-contact/blob/17.0/base_location/views/res_partner_view.xml, with possibly also its _fields_view_get override if needed, to accomplish the same UX than the partner view

[BernatObrador]

Hi @ivantodorovich, thanks for your feedback.

The thing is that it really needs the overwritten write method, otherwise it ends up throwing errors due to mismatches in partner fields.

For example, when you change the ZIP code or use the autocomplete in the field service location, saving will throw an error because the partner data does not match the ZIP.

The only solution I found was to overwrite the write method.

Regarding the module name, fieldservice_base_location is fine for me.

Let me know your thoughts!

[ivantodorovich]

Thanks @BernatObrador

Is this covered by the unit tests you wrote?
Meaning, would they fail without the write override?

If we keep it, then, please write a detailed comment explaining the error you get and how this solves it.

def write(self, vals):
    # OVERRIDE to ...
    # ...
    # ...

[ivantodorovich]

What's this for?

Suggested change

	@classmethod
	def _request_handler(cls, s, r, /, **kw):
	"""Don't block external requests."""
	return cls._super_send(s, r, **kw)

[ivantodorovich]

Thanks @BernatObrador

Is this covered by the unit tests you wrote?
Meaning, would they fail without the write override?

If we keep it, then, please write a detailed comment explaining the error you get and how this solves it.

def write(self, vals):
    # OVERRIDE to ...
    # ...
    # ...