[17.0][MIG] hr_attendance_validation #221
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module allow to review attendance per weeks and generate proper compensatory hours And apply suggestions from code review Co-authored-by: aleuffre <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-attendance-14.0/hr-attendance-14.0-hr_attendance_validation Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-14-0/hr-attendance-14-0-hr_attendance_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-attendance-14.0/hr-attendance-14.0-hr_attendance_validation Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-14-0/hr-attendance-14-0-hr_attendance_validation/
Currently translated at 100.0% (85 of 85 strings) Translation: hr-attendance-14.0/hr-attendance-14.0-hr_attendance_validation Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-14-0/hr-attendance-14-0-hr_attendance_validation/it/
Currently translated at 100.0% (85 of 85 strings) Translation: hr-attendance-14.0/hr-attendance-14.0-hr_attendance_validation Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-14-0/hr-attendance-14-0-hr_attendance_validation/it/
we are using hr.leaves to manage allowed remote days but we don't want to remove thoses times in attendance validation
Currently translated at 100.0% (87 of 87 strings) Translation: hr-attendance-14.0/hr-attendance-14.0-hr_attendance_validation Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-14-0/hr-attendance-14-0-hr_attendance_validation/it/
…ue for analysis purpose * store existing fields to be used in pivot view * add new field to report compensatory leaves taken
Use start/end validation sheet dates to compute theorical time taking care of bank holidays
* hr_holidays_public: fix calendar.get_work_hours_count * hr_attendance_overtime: standard migration * hr_attendance_modification_tracking: standard migration
petrus-v
force-pushed
the
17.0-mig-hr_attendance_validation
branch
3 times, most recently
from
df306b0 to
683fcfd
Compare
petrus-v
force-pushed
the
17.0-mig-hr_attendance_validation
branch
from
683fcfd to
274b272
Compare
Compensatory Allocation and adjustement hours now rely on Odoo standard hr.attendance.overtime
petrus-v
force-pushed
the
17.0-mig-hr_attendance_validation
branch
from
274b272 to
12235e0
Compare
petrus-v
commented
May 27, 2025
Comment on lines
+352
to
+362
| record.adjustment_overtime_id = self.env[ | ||
| "hr.attendance.overtime" | ||
| ].create( | ||
| { | ||
| "employee_id": record.employee_id.id, | ||
| "date": record.date_to, | ||
| "duration": duration, | ||
| "duration_real": duration, | ||
| "adjustment": True, | ||
| } | ||
| ) |
There was a problem hiding this comment.
Hum... bypassing hr.leave.allocation and hr.leave is breaking hr.leave.report so probably better to re-add them to be able:
- properly display report
- be able to create different leave.type per year
As far I remember I've chosen to create those line directly to avoid constraints on hr.leave which is hard to guess, I'll have to find a way to avoid those constraints.
The other approach would be to change the hr.leave.allocation request 🤔
There was a problem hiding this comment.
hum using odoo 17.0 without this module we are getting the same issue, accrued compensatory hours are not displayed. it's probably better to create a dedicated module or create a PR against Odoo 🤔
petrus-v
commented
May 27, 2025
| <field name="sequence">4</field> | ||
| </record> --> | ||
|
|
||
| </odoo> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate backend stuff:
As the new hr.attendance.overtime we use it as standard backend to store adjustement hours.
this gives the opportunity to configure on employee if it compute compensatory hours are weekly or daily base. For daily base this is the Odoo standard so it's out of the scope of the weekly validation.
allow negative compensatory hours (this should probably extract in an independent module (I'll add it in the roadmap)
make sure readme is updated
migrate frontend source code to the used from attendance widget