Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OCA/product-configurator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f009b7136c7682900de28359604a3f6478cd259e
Choose a base ref
..
head repository: OCA/product-configurator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 588788a057041dae2344fd3fd2a4a2af8118b2a4
Choose a head ref
Showing with 3 additions and 1 deletion.
  1. +3 −1 website_product_configurator/models/product_template.py
4 changes: 3 additions & 1 deletion website_product_configurator/models/product_template.py
Original file line number Diff line number Diff line change
@@ -36,7 +36,9 @@ def _get_possible_combinations(
# because it is actually a flag in the pta.
# super() would get stuck trying any possible combination
# for filling the missing ptav.
yield necessary_values
yield necessary_values or self.env[
"product.template.attribute.value"
].browse()

def _is_combination_possible_by_config(self, combination, ignore_no_variant=False):
self.ensure_one()

Check warning on line 44 in website_product_configurator/models/product_template.py

Codecov / codecov/patch

website_product_configurator/models/product_template.py#L44

Added line #L44 was not covered by tests