[IMP] project_task_prioritize: add form view and today in formula paramenters.

Author: DavidJForgeFlow

project_task_prioritize/models/project.py

@@ -14,6 +14,7 @@ class ProjectProject(models.Model):
             "# - prioritizer_sum: sum of prioritizer line values\n"
             "# - max_value: sum of max values from prioritizer categories\n"
             "# - allocated_hours: hours allocated to the project/task\n"
+            "# - today: datetime.datetime.today()\n"
             "# - rec: current record (project/task)\n"
             "\n"
             "# Example:\n"

project_task_prioritize/models/project_task.py

@@ -1,8 +1,13 @@
 # Copyright 2025 ForgeFlow S.L. (https://www.forgeflow.com)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+import datetime
+import logging
+
 from odoo import api, fields, models
 from odoo.tools.safe_eval import safe_eval
 
+_logger = logging.getLogger(__name__)
+
 
 class ProjectTask(models.Model):
     _inherit = "project.task"
@@ -21,10 +26,12 @@ def _compute_prioritizer_value(self):
                 "prioritizer_sum": prioritizer_sum,
                 "max_value": max_value,
                 "allocated_hours": rec.allocated_hours,
+                "today": datetime.datetime.today(),
                 "rec": rec,
             }
             formula = rec.project_id.prioritizer_formula or "0"
             try:
                 rec.prioritizer_value = safe_eval(formula, locals_dict=locals_dict)
-            except Exception:
+            except Exception as e:
+                _logger.error(e)
                 rec.prioritizer_value = 0

project_task_prioritize/tests/test_prioritizer_category.py

@@ -10,7 +10,7 @@ def setUp(self):
         self.PrioritizerCategory = self.env["prioritizer.category"]
         self.PrioritizerCategoryLine = self.env["prioritizer.category.line"]
 
-    def test_create_prioritizer_category(self):
+    def test_01_create_prioritizer_category(self):
         """Test creation of a prioritizer category with lines"""
         # Create a prioritizer category with lines
         category = self.PrioritizerCategory.create(
@@ -26,7 +26,7 @@ def test_create_prioritizer_category(self):
         self.assertEqual(len(category.prioritizer_category_line_ids), 3)
         self.assertEqual(category.max_value, 3)
 
-    def test_compute_max_value(self):
+    def test_02_compute_max_value(self):
         """Test computation of max_value field"""
         # Create a prioritizer category with lines
         category = self.PrioritizerCategory.create(
@@ -50,7 +50,7 @@ def test_compute_max_value(self):
         )
         self.assertEqual(category.max_value, 15)
 
-    def test_empty_category(self):
+    def test_03_empty_category(self):
         """Test behavior with empty category"""
         category = self.PrioritizerCategory.create({"name": "Empty Category"})
         self.assertEqual(category.max_value, 1)  # Default value when no lines exist

project_task_prioritize/tests/test_project_task.py

@@ -1,6 +1,8 @@
 # Copyright 2025 ForgeFlow S.L. (https://www.forgeflow.com)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
+import datetime
+
 from odoo.tests import common
 
 
@@ -46,7 +48,7 @@ def setUp(self):
             }
         )
 
-    def test_task_prioritizer_value(self):
+    def test_01_task_prioritizer_value(self):
         """Test computation of prioritizer_value"""
         # Create a task
         task = self.ProjectTask.create(
@@ -74,7 +76,7 @@ def test_task_prioritizer_value(self):
         expected_value = (3 + 5) / (10 * (3 + 5 - (3 + 5) + 1))  # Default formula
         self.assertEqual(task.prioritizer_value, expected_value)
 
-    def test_custom_prioritizer_formula(self):
+    def test_02_custom_prioritizer_formula(self):
         """Test custom prioritizer formula"""
         # Set a custom formula
         custom_formula = "prioritizer_sum / allocated_hours"
@@ -103,7 +105,7 @@ def test_custom_prioritizer_formula(self):
         # Test with custom formula (3 + 5) / 4 = 2.0
         self.assertEqual(task.prioritizer_value, 2.0)
 
-    def test_invalid_formula(self):
+    def test_03_invalid_formula(self):
         """Test behavior with invalid formula"""
         # Set an invalid formula
         self.project.write(
@@ -127,3 +129,33 @@ def test_invalid_formula(self):
 
         # Should default to 0 on error
         self.assertEqual(task.prioritizer_value, 0)
+
+    def test_04_using_today_value(self):
+        """Test custom prioritizer formula"""
+        # Set a custom formula
+        custom_formula = "(rec.date_deadline - today).days / allocated_hours"
+        self.project.write({"prioritizer_formula": custom_formula})
+
+        # Create a task
+        task = self.ProjectTask.create(
+            {
+                "name": "Custom Formula Task",
+                "project_id": self.project.id,
+                "allocated_hours": 4,
+                "date_deadline": datetime.datetime.today() + datetime.timedelta(days=8),
+            }
+        )
+
+        # Assign prioritizer lines (High importance = 3, High urgency = 5)
+        importance_high = self.category1.prioritizer_category_line_ids.filtered(
+            lambda x: x.name == "High"
+        )
+        urgency_high = self.category2.prioritizer_category_line_ids.filtered(
+            lambda x: x.name == "High"
+        )
+        task.write(
+            {"prioritizer_line_ids": [(6, 0, (importance_high + urgency_high).ids)]}
+        )
+
+        # Test with custom formula 7 / 4 = 1.75
+        self.assertEqual(task.prioritizer_value, 1.75)

project_task_prioritize/tests/test_project_task_prioritizer.py

@@ -45,7 +45,7 @@ def setUp(self):
             }
         )
 
-    def test_prioritizer_wizard_default_get(self):
+    def test_01_prioritizer_wizard_default_get(self):
         """Test default_get method of the wizard"""
         # Create wizard with task context
         wizard = self.ProjectTaskPrioritizer.with_context(
@@ -58,7 +58,7 @@ def test_prioritizer_wizard_default_get(self):
         self.assertIn(self.task1, wizard.task_ids)
         self.assertIn(self.task2, wizard.task_ids)
 
-    def test_prioritizer_wizard_validate(self):
+    def test_02_prioritizer_wizard_validate(self):
         """Test button_validate method of the wizard"""
         # Get category lines
         importance_high = self.category1.prioritizer_category_line_ids.filtered(
@@ -87,7 +87,7 @@ def test_prioritizer_wizard_validate(self):
         self.assertEqual(self.task1.prioritizer_line_ids, importance_high)
         self.assertEqual(self.task2.prioritizer_line_ids, importance_medium)
 
-    def test_prioritizer_wizard_no_tasks(self):
+    def test_03_prioritizer_wizard_no_tasks(self):
         """Test wizard with no tasks in context"""
         # Create wizard with no task context
         wizard = self.ProjectTaskPrioritizer.with_context(
@@ -98,15 +98,15 @@ def test_prioritizer_wizard_no_tasks(self):
         self.assertEqual(len(wizard.task_ids), 0)
         self.assertEqual(len(wizard.line_ids), 0)
 
-    def test_prioritizer_wizard_wrong_model(self):
+    def test_04_prioritizer_wizard_wrong_model(self):
         """Test wizard with wrong model in context"""
         # Should raise assertion for wrong model
         with self.assertRaises(AssertionError):
             self.ProjectTaskPrioritizer.with_context(
                 active_model="wrong.model", active_ids=[1, 2, 3]
             ).create({})
 
-    def test_prioritizer_wizard_line_creation(self):
+    def test_05_prioritizer_wizard_line_creation(self):
         """Test _get_matrix_lines method"""
         # Create a second category
         category2 = self.PrioritizerCategory.create(

project_task_prioritize/views/prioritizer_category_views.xml

@@ -14,15 +14,36 @@
             </list>
         </field>
     </record>
-    <record id="prioritizer_category_line_list" model="ir.ui.view">
-        <field name="name">prioritizer.category.line.list</field>
-        <field name="model">prioritizer.category.line</field>
+    <record id="prioritizer_category_form" model="ir.ui.view">
+        <field name="name">prioritizer.category.form</field>
+        <field name="model">prioritizer.category</field>
         <field name="arch" type="xml">
-            <list>
-                <field name="prioritizer_category_id" />
-                <field name="name" />
-                <field name="value" />
-            </list>
+            <form>
+                <sheet>
+                    <div class="oe_title">
+                        <h1 class="d-flex">
+                            <field name="name" placeholder="New Category" nolabel="1" />
+                        </h1>
+                    </div>
+                    <group>
+                        <field name="max_value" readonly="1" />
+                    </group>
+                    <notebook>
+                        <page name="category_lines" string="Category Lines">
+                            <field name="prioritizer_category_line_ids">
+                                <list editable="bottom">
+                                    <field name="name" />
+                                    <field name="value" />
+                                    <field
+                                        name="prioritizer_category_id"
+                                        invisible="1"
+                                    />
+                                </list>
+                            </field>
+                        </page>
+                    </notebook>
+                </sheet>
+            </form>
         </field>
     </record>
 
@@ -33,13 +54,6 @@
         <field name="target">main</field>
         <field name="view_id" ref="prioritizer_category_list" />
     </record>
-    <record id="action_prioritizer_category_line" model="ir.actions.act_window">
-        <field name="name">Prioritizer Category Line</field>
-        <field name="res_model">prioritizer.category.line</field>
-        <field name="view_mode">list,form</field>
-        <field name="target">main</field>
-        <field name="view_id" ref="prioritizer_category_line_list" />
-    </record>
     <menuitem
         id="menu_prioritizer"
         parent="project.menu_project_config"
@@ -52,10 +66,4 @@
         action="action_prioritizer_category"
         sequence="1"
     />
-    <menuitem
-        id="menu_action_prioritizer_category_line"
-        parent="menu_prioritizer"
-        action="action_prioritizer_category_line"
-        sequence="2"
-    />
 </odoo>

project_task_prioritize/wizards/project_task_prioritizer_view.xml

@@ -27,7 +27,7 @@
                             <field
                                 name="prioritizer_category_line_id"
                                 options='{"no_create": True, "no_open": True}'
-                                domain="[('prioritizer_category_id','in', prioritizer_category_id)]"
+                                domain="[('prioritizer_category_id','=', prioritizer_category_id)]"
                             />
                             <field name="task_id" invisible="1" />
                             <field name="prioritizer_category_id" invisible="1" />