diff --git a/sale_order_line_remove/README.rst b/sale_order_line_remove/README.rst new file mode 100644 index 00000000000..f426a523a36 --- /dev/null +++ b/sale_order_line_remove/README.rst @@ -0,0 +1,90 @@ +====================== +Sale Order Line Remove +====================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:19987b79fe99d4ff465bda1d9b1f07c5570e70b5347127ddb2dcc5849efb6bc4 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github + :target: https://github.com/OCA/sale-workflow/tree/18.0/sale_order_line_remove + :alt: OCA/sale-workflow +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_order_line_remove + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=18.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module allows the removal of sale order lines even after the order +has been confirmed, under certain conditions. Specifically, a sale order +line can be removed if: + +- It has not been invoiced. +- It has not been delivered. + +**Table of contents** + +.. contents:: + :local: + +Usage +===== + +Once the module is installed: + +1. Go to a sale order. +2. You can now delete a sale order line if it hasn't been invoiced or + delivered. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* ForgeFlow + +Contributors +------------ + +- Joan Sisquella + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/sale-workflow `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/sale_order_line_remove/__init__.py b/sale_order_line_remove/__init__.py new file mode 100644 index 00000000000..0650744f6bc --- /dev/null +++ b/sale_order_line_remove/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/sale_order_line_remove/__manifest__.py b/sale_order_line_remove/__manifest__.py new file mode 100644 index 00000000000..1661f89b47e --- /dev/null +++ b/sale_order_line_remove/__manifest__.py @@ -0,0 +1,16 @@ +# Copyright 2023 ForgeFlow, S.L. (https://www.forgeflow.com) +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). +{ + "name": "Sale Order Line Remove", + "version": "18.0.1.0.0", + "category": "Sales", + "summary": "Allows removal of sale order lines from confirmed " + "orders if not invoiced or received", + "author": "ForgeFlow, Odoo Community Association (OCA)", + "website": "https://github.com/OCA/sale-workflow", + "license": "AGPL-3", + "depends": ["sale_stock"], + "data": [], + "installable": True, + "application": False, +} diff --git a/sale_order_line_remove/i18n/sale_order_line_remove.pot b/sale_order_line_remove/i18n/sale_order_line_remove.pot new file mode 100644 index 00000000000..12b0de40c2a --- /dev/null +++ b/sale_order_line_remove/i18n/sale_order_line_remove.pot @@ -0,0 +1,31 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * sale_order_line_remove +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 15.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: sale_order_line_remove +#: model:ir.model,name:sale_order_line_remove.model_sale_order_line +msgid "Sales Order Line" +msgstr "" + +#. module: sale_order_line_remove +#: code:addons/sale_order_line_remove/models/sale_order.py:0 +#, python-format +msgid "You can not remove an order line that has been delivered" +msgstr "" + +#. module: sale_order_line_remove +#: code:addons/sale_order_line_remove/models/sale_order.py:0 +#, python-format +msgid "You can not remove an order line that has been invoiced" +msgstr "" diff --git a/sale_order_line_remove/models/__init__.py b/sale_order_line_remove/models/__init__.py new file mode 100644 index 00000000000..6aacb753131 --- /dev/null +++ b/sale_order_line_remove/models/__init__.py @@ -0,0 +1 @@ +from . import sale_order diff --git a/sale_order_line_remove/models/sale_order.py b/sale_order_line_remove/models/sale_order.py new file mode 100644 index 00000000000..7f3cc907bb9 --- /dev/null +++ b/sale_order_line_remove/models/sale_order.py @@ -0,0 +1,46 @@ +# Copyright 2023 ForgeFlow, S.L. (https://www.forgeflow.com) +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). + +from odoo import _, models +from odoo.exceptions import UserError + + +class SaleOrderLine(models.Model): + _inherit = "sale.order.line" + + def _check_line_unlink(self): + non_removable_lines = super()._check_line_unlink() + removable_lines = self.filtered( + lambda line: line.state in ("sale", "done") + and not line.invoice_lines + and not line.move_ids.filtered(lambda move: move.state == "done") + ) + invoiced_lines = self.sudo().filtered( + lambda line: line.state in ("sale", "done") and line.invoice_lines + ) + if invoiced_lines: + raise UserError( + _("You can not remove an order line that has been invoiced") + ) + delivered_lines = self.sudo().filtered( + lambda line: line.state in ("sale", "done") + and line.move_ids.filtered(lambda move: move.state == "done") + ) + if delivered_lines: + raise UserError( + _("You can not remove an order line that has been delivered") + ) + return non_removable_lines - removable_lines + + def unlink(self): + non_removable_lines = self._check_line_unlink() + for line in self - non_removable_lines: + related_pickings = line.move_ids.mapped("picking_id") + line.move_ids.filtered( + lambda move: move.state not in ("done", "cancel") + )._action_cancel() + line.move_ids.filtered(lambda move: move.state != "done").unlink() + for picking in related_pickings: + if not picking.move_ids_without_package: + picking.unlink() + return super().unlink() diff --git a/sale_order_line_remove/pyproject.toml b/sale_order_line_remove/pyproject.toml new file mode 100644 index 00000000000..4231d0cccb3 --- /dev/null +++ b/sale_order_line_remove/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/sale_order_line_remove/readme/CONTRIBUTORS.md b/sale_order_line_remove/readme/CONTRIBUTORS.md new file mode 100644 index 00000000000..39034f212d0 --- /dev/null +++ b/sale_order_line_remove/readme/CONTRIBUTORS.md @@ -0,0 +1 @@ +- Joan Sisquella \<\> diff --git a/sale_order_line_remove/readme/DESCRIPTION.md b/sale_order_line_remove/readme/DESCRIPTION.md new file mode 100644 index 00000000000..593ed1efdc3 --- /dev/null +++ b/sale_order_line_remove/readme/DESCRIPTION.md @@ -0,0 +1,6 @@ +This module allows the removal of sale order lines even after the order +has been confirmed, under certain conditions. Specifically, a sale order +line can be removed if: + +- It has not been invoiced. +- It has not been delivered. diff --git a/sale_order_line_remove/readme/USAGE.md b/sale_order_line_remove/readme/USAGE.md new file mode 100644 index 00000000000..65a6e577552 --- /dev/null +++ b/sale_order_line_remove/readme/USAGE.md @@ -0,0 +1,5 @@ +Once the module is installed: + +1. Go to a sale order. +2. You can now delete a sale order line if it hasn't been invoiced or + delivered. diff --git a/sale_order_line_remove/static/description/icon.png b/sale_order_line_remove/static/description/icon.png new file mode 100644 index 00000000000..3a0328b516c Binary files /dev/null and b/sale_order_line_remove/static/description/icon.png differ diff --git a/sale_order_line_remove/static/description/index.html b/sale_order_line_remove/static/description/index.html new file mode 100644 index 00000000000..938a8a60108 --- /dev/null +++ b/sale_order_line_remove/static/description/index.html @@ -0,0 +1,439 @@ + + + + + +Sale Order Line Remove + + + +
+

Sale Order Line Remove

+ + +

Beta License: AGPL-3 OCA/sale-workflow Translate me on Weblate Try me on Runboat

+

This module allows the removal of sale order lines even after the order +has been confirmed, under certain conditions. Specifically, a sale order +line can be removed if:

+
    +
  • It has not been invoiced.
    • +
  • It has not been delivered.
    • +
+

Table of contents

+ +
+

Usage

+

Once the module is installed:

+
    +
  1. Go to a sale order.
    2. +
  2. You can now delete a sale order line if it hasn’t been invoiced or +delivered.
    3. +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • ForgeFlow
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/sale-workflow project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/sale_order_line_remove/tests/__init__.py b/sale_order_line_remove/tests/__init__.py new file mode 100644 index 00000000000..2283b3b0b2f --- /dev/null +++ b/sale_order_line_remove/tests/__init__.py @@ -0,0 +1 @@ +from . import test_sale_order_line diff --git a/sale_order_line_remove/tests/test_sale_order_line.py b/sale_order_line_remove/tests/test_sale_order_line.py new file mode 100644 index 00000000000..6c1a4d1c718 --- /dev/null +++ b/sale_order_line_remove/tests/test_sale_order_line.py @@ -0,0 +1,155 @@ +# Copyright 2023 ForgeFlow, S.L. (https://www.forgeflow.com) +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). + +from odoo.exceptions import UserError +from odoo.tests import TransactionCase + + +class TestSaleOrderLine(TransactionCase): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.SaleOrder = cls.env["sale.order"] + cls.SaleOrderLine = cls.env["sale.order.line"] + cls.partner = cls.env.ref("base.res_partner_2") + cls.product = cls.env.ref("product.product_product_4") + cls.uom = cls.env.ref("uom.product_uom_unit") + + def test_check_line_unlink(self): + sale_order = self.SaleOrder.create({"partner_id": self.partner.id}) + sale_order.action_confirm() + sale_order_line = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + non_removable_lines = sale_order_line._check_line_unlink() + self.assertFalse(non_removable_lines, "Line should not be non-removable") + + def test_unlink(self): + sale_order = self.SaleOrder.create({"partner_id": self.partner.id}) + sale_order.action_confirm() + sale_order_line = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + sale_order_line.unlink() + self.assertFalse(sale_order_line.exists(), "Sale order line was not deleted") + + def test_check_line_not_unlinkable(self): + sale_order = self.SaleOrder.create({"partner_id": self.partner.id}) + sale_order.action_confirm() + sale_order_line = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + picking = sale_order.picking_ids[0] + picking.action_confirm() + picking.action_assign() + for move in picking.move_ids_without_package: + move.quantity = move.product_uom_qty + picking.button_validate() + with self.assertRaises(UserError): + sale_order_line._check_line_unlink() + + def test_not_unlinkable_after_picking(self): + sale_order = self.SaleOrder.create({"partner_id": self.partner.id}) + sale_order.action_confirm() + sale_order_line = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + picking = sale_order.picking_ids[0] + picking.action_confirm() + picking.action_assign() + for move in picking.move_ids_without_package: + move.quantity = move.product_uom_qty + picking.button_validate() + with self.assertRaises(UserError): + sale_order_line.unlink() + + def test_check_line_unlink_delivered(self): + sale_order = self.SaleOrder.create({"partner_id": self.partner.id}) + sale_order.action_confirm() + sale_order_line = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + picking = sale_order.picking_ids[0] + picking.action_confirm() + picking.action_assign() + for move in picking.move_ids_without_package: + move.quantity = move.product_uom_qty + picking.button_validate() + with self.assertRaises(UserError): + sale_order_line._check_line_unlink() + + def test_check_line_unlink_invoiced(self): + sale_order = self.SaleOrder.create({"partner_id": self.partner.id}) + sale_order.action_confirm() + sale_order_line = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + picking = sale_order.picking_ids[0] + picking.action_confirm() + picking.action_assign() + for move in picking.move_ids_without_package: + move.quantity = move.product_uom_qty + picking.button_validate() + sale_order._create_invoices() + with self.assertRaises(UserError): + sale_order_line._check_line_unlink() + + def test_unlink_empty_picking(self): + sale_order = self.SaleOrder.create({"partner_id": self.partner.id}) + sale_order.action_confirm() + sale_order_line1 = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + sale_order_line2 = self.SaleOrderLine.create( + { + "order_id": sale_order.id, + "product_id": self.product.id, + "product_uom_qty": 1, + "product_uom": self.uom.id, + } + ) + picking = sale_order.picking_ids[0] + picking.action_confirm() + picking.action_assign() + sale_order_line1.unlink() + self.assertTrue(picking.exists(), "Picking was deleted") + self.assertNotEqual( + picking.state, "cancel", "Picking should not be cancelled yet" + ) + sale_order_line2.unlink() + self.assertFalse(picking.exists(), "Picking was not deleted")