[MIG] base_tier_validation_report: Migration to 18.0

Author: ntsirintanis

base_tier_validation_report/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Base Tier Validation - Reports",
     "summary": "Reports related to tier validation",
-    "version": "16.0.1.0.1",
+    "version": "18.0.1.0.0",
     "category": "Tools",
     "website": "https://github.com/OCA/server-ux",
     "author": "Ecosoft, Odoo Community Association (OCA)",

base_tier_validation_report/models/tier_review.py

@@ -16,14 +16,15 @@ class TierReview(models.Model):
     )
     resource_type = fields.Selection(
         selection="_selection_resource_ref",
+        compute="_compute_display_fields",
         compute_sudo=True,
     )
     resource_name = fields.Char(
-        compute="_compute_resource_ref",
+        compute="_compute_display_fields",
         compute_sudo=True,
     )
     next_review = fields.Char(
-        compute="_compute_resource_ref",
+        compute="_compute_display_fields",
         compute_sudo=True,
     )
 
@@ -35,12 +36,14 @@ def _selection_resource_ref(self):
     @api.depends("model", "res_id")
     def _compute_resource_ref(self):
         for rec in self:
-            rec.resource_ref = (
-                "%s,%s" % (rec.model, rec.res_id) if rec.res_id else False
-            )
-            rec.resource_name = rec.resource_ref.display_name
+            rec.resource_ref = f"{rec.model},{rec.res_id}" if rec.res_id else False
+
+    @api.depends("model", "res_id", "resource_ref")
+    def _compute_display_fields(self):
+        for rec in self:
             rec.resource_type = rec.model
-            rec.next_review = rec.resource_ref.next_review
+            rec.resource_name = rec.resource_ref.display_name
+            rec.next_review = rec.next_review
 
     def action_open_resource_ref(self):
         self.ensure_one()

base_tier_validation_report/reports/tier_review_report.xml

@@ -4,7 +4,7 @@
         <field name="model">tier.review</field>
         <field name="priority" eval="100" />
         <field name="arch" type="xml">
-            <tree
+            <list
                 decoration-danger="status=='rejected'"
                 decoration-success="status=='approved'"
                 create="0"
@@ -30,12 +30,12 @@
                 <field name="reviewed_date" optional="hide" />
                 <field name="comment" optional="hide" />
                 <field name="next_review" string="" />
-            </tree>
+            </list>
         </field>
     </record>
 
     <record id="tier_review_report_form" model="ir.ui.view">
-        <field name="name">tier.review.report.tree</field>
+        <field name="name">tier.review.report.form</field>
         <field name="model">tier.review</field>
         <field name="arch" type="xml">
             <form create="0" edit="0" delete="0">
@@ -107,7 +107,7 @@
         <field name="name">My Reviews</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">tier.review</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="domain">[("reviewer_ids", "in", uid)]</field>
         <field name="context">{"search_default_pending": True}</field>
         <field name="view_id" ref="tier_review_report_tree" />
@@ -118,7 +118,7 @@
         <field name="name">All Reviews</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">tier.review</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="context">{}</field>
         <field name="view_id" ref="tier_review_report_tree" />
         <field name="search_view_id" ref="tier_review_report_search" />
@@ -128,12 +128,7 @@
         />
     </record>
 
-    <menuitem
-        id="menu_tier_validation_report"
-        name="Reviews"
-        parent="base.menu_board_root"
-        sequence="3"
-    />
+    <menuitem id="menu_tier_validation_report" name="Reviews" sequence="30" />
     <menuitem
         id="menu_tier_review_report_my"
         parent="menu_tier_validation_report"