Skip to content

Commit 4004a3e

Browse files
committed
[FIX] base_cancel_confirm: split method to update value in docs
1 parent befb58c commit 4004a3e

File tree

2 files changed

+23
-16
lines changed

2 files changed

+23
-16
lines changed

base_cancel_confirm/model/base_cancel_confirm.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,16 @@ def open_cancel_confirm_wizard(self):
5454
}
5555
return action
5656

57+
def _get_value_clear_cancel(self):
58+
return {
59+
"cancel_confirm": False,
60+
"cancel_reason": False,
61+
"cancel_by": False,
62+
"cancel_date": False,
63+
}
64+
5765
def clear_cancel_confirm_data(self):
58-
self.write(
59-
{
60-
"cancel_confirm": False,
61-
"cancel_reason": False,
62-
"cancel_by": False,
63-
"cancel_date": False,
64-
}
65-
)
66+
self.write(self._get_value_clear_cancel())
6667

6768
def get_view(self, view_id=None, view_type="form", **options):
6869
res = super().get_view(view_id=view_id, view_type=view_type, **options)

base_cancel_confirm/wizard/cancel_confirm.py

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,27 @@ class CancelConfirm(models.TransientModel):
1818
required=True,
1919
)
2020

21-
def confirm_cancel(self):
22-
self.ensure_one()
23-
res_model = self._context.get("cancel_res_model")
24-
res_ids = self._context.get("cancel_res_ids")
25-
cancel_method = self._context.get("cancel_method")
26-
docs = self.env[res_model].browse(res_ids)
27-
docs.write({"cancel_confirm": True})
21+
def _get_dict_udpate(self):
22+
"""Hooks this method to update value in docs"""
23+
dict_update = {"cancel_confirm": True}
2824
# Cancel Reason
2925
if self.has_cancel_reason in ["optional", "required"]:
30-
docs.write(
26+
dict_update.update(
3127
{
3228
"cancel_reason": self.cancel_reason,
3329
"cancel_by": self.env.user,
3430
"cancel_date": fields.Date.context_today(self),
3531
}
3632
)
33+
return dict_update
34+
35+
def confirm_cancel(self):
36+
self.ensure_one()
37+
res_model = self._context.get("cancel_res_model")
38+
res_ids = self._context.get("cancel_res_ids")
39+
cancel_method = self._context.get("cancel_method")
40+
docs = self.env[res_model].browse(res_ids)
41+
dict_update = self._get_dict_udpate()
42+
docs.write(dict_update)
3743
res = getattr(docs, cancel_method)()
3844
return res

0 commit comments

Comments
 (0)