[17.0][IMP] mail_send_confirmation: wizard #1544
Open
+36
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostashiro
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Functional test. LGTM.
@alexey-pelykh Could this approach also work on the Send button of the quick composer, which is currently handled by JS?
|
@yostashiro thanks for the review! As for your question - for quick composer it has to be done via JS as it's a custom component, see https://github.com/odoo/odoo/blob/9af66f9ef02c7412aac5c31eb9ca631b8cf57332/addons/mail/static/src/core/common/composer.js |
gbrito
approved these changes
Jan 17, 2025
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add confirmation to the wizard as well since even though the emails are shown in both cases, a confirmation reduces wrongfully sent messages
