Skip to content

Commit 28f0455

Browse files
committed
[REF] web_form_banner: JS
- Switch to the ESM style - Change var to const/let - Remove unused parts (diff, el.dataset.wfbTriggerFields)
1 parent 8f636ba commit 28f0455

File tree

2 files changed

+187
-209
lines changed

2 files changed

+187
-209
lines changed

web_form_banner/models/web_form_banner_rule.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@
1010
from lxml import etree
1111
from pytz import timezone
1212

13-
from odoo import _, api, fields, models
13+
from odoo import _, api, fields, models, tools
1414
from odoo.exceptions import ValidationError
15-
from odoo.tools import html_escape, safe_eval
15+
from odoo.tools import html_escape
1616
from odoo.tools.float_utils import float_compare, float_is_zero, float_round
17+
from odoo.tools.safe_eval import safe_eval
1718

1819
_logger = logging.getLogger(__name__)
1920

@@ -175,8 +176,8 @@ def _build_form_url(self, rec):
175176
def _base_eval_ctx_static(self):
176177
# Only static, import-heavy items
177178
return {
178-
"time": safe_eval.time,
179-
"datetime": safe_eval.datetime,
179+
"time": tools.safe_eval.time,
180+
"datetime": tools.safe_eval.datetime,
180181
"dateutil": {
181182
"parser": dateparse,
182183
"relativedelta": relativedelta,
@@ -236,9 +237,9 @@ def _run_rule_code(self, rule, eval_ctx):
236237
return {}
237238
code = rule.message_value_code.strip()
238239
try:
239-
out = safe_eval.safe_eval(code, eval_ctx, mode="eval") or {}
240+
out = safe_eval(code, eval_ctx, mode="eval") or {}
240241
except Exception:
241-
safe_eval.safe_eval(code, eval_ctx, mode="exec", nocopy=True)
242+
safe_eval(code, eval_ctx, mode="exec", nocopy=True)
242243
out = eval_ctx.get("result") or {}
243244
return out if isinstance(out, dict) else {}
244245

0 commit comments

Comments
 (0)