Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oe4t-patches-l4t-r32.7] Device tree for Jetson Xavier NX Dev Kit #36

Open
pticon opened this issue Aug 4, 2022 · 5 comments
Open

[oe4t-patches-l4t-r32.7] Device tree for Jetson Xavier NX Dev Kit #36

pticon opened this issue Aug 4, 2022 · 5 comments

Comments

@pticon
Copy link

pticon commented Aug 4, 2022

I am trying compile the device tree for the Jetson Xavier NX Dev Kit (P3668-0000). So I am using that DTS tegra194-p3668-all-p3509-0000.dts, but I got an error with the "i2c7" label because it does not exist:
ERROR (phandle_references): Reference to non-existent node or label "i2c7"

The only one reference for this label is there:

But indeed, this label is never defined.

I also checked the pinmux about that i2c7 and it is also unused. Am I missing anything here ?

By just commenting out the line, I was able to compile it.

Thank you for your support.

@madisongh
Copy link
Member

Are you compiling the device tree from within the kernel build system, or trying to do so manually? That label is defined in tegra194-soc-i2c.dtsi, which is several layers of #include down from the main device tree file. If it's a kernel build, can you attach a log (with V=1 output)? If it's manual, what command options are you using, and do they align with what the kernel build does (include paths, -D definitions, etc.)?

@pticon
Copy link
Author

pticon commented Aug 8, 2022

Hi @madisongh,
Thanks for your reply.

I understand what you meant and the file you pointed is indeed defining that value.

I am compiling using the meta-tegra with a separate source directory.
Here is the command I am using:
mkdir -p arch/arm64/boot/dts/_ddot_/_ddot_/_ddot_/_ddot_/nvidia/platform/t19x/jakku/kernel-dts/ ; aarch64-linux-gcc -E -Wp,-MD,arch/arm64/boot/dts/_ddot_/_ddot_/_ddot_/_ddot_/nvidia/platfo rm/t19x/jakku/kernel-dts/.tegra194-p3668-all-p3509-0000.dtb.d.pre.tmp -nostdinc -I/home/pierre/Sources/linux-tegra-4.9/nvidia/soc/tegra/kernel-include -I/home/pierre/Sources/linux-tegra-4.9/ nvidia/platform/tegra/common/kernel-dts -DLINUX_VERSION=409 -I/home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t210/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t210/comm on/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t210b01/common/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t210/porg/kernel-dts -I/home/pierre/Sour ces/linux-tegra-4.9/nvidia/soc/t18x/kernel-include -I/home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t18x/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t18x/common/kernel -dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t19x/kernel-include -I/home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t18x/kernel-include -I/home/pierre/Sources/linux-tegra-4.9/nvidia /soc/t19x/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/common/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t23x/kernel-include -I/home/pierre/Source s/linux-tegra-4.9/nvidia/soc/t23x/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t18x/lanai/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t18x/quill/ke rnel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/galen/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/galen-industrial/kernel-dts -I/home/pierre/S ources/linux-tegra-4.9/nvidia/platform/t19x/jakku/kernel-dts -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/ -I/home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/mccoy/ke rnel-dts -undef -D__DTS__ -x assembler-with-cpp -o arch/arm64/boot/dts/_ddot_/_ddot_/_ddot_/_ddot_/nvidia/platform/t19x/jakku/kernel-dts/.tegra194-p3668-all-p3509-0000.dtb.dts.tmp /home/pier re/Sources/linux-tegra-4.9/arch/arm64/boot/dts/../../../../nvidia/platform/t19x/jakku/kernel-dts/tegra194-p3668-all-p3509-0000.dts ; ./scripts/dtc/dtc -@ -O dtb -o arch/arm64/boot/dts/_ddot_ /_ddot_/_ddot_/_ddot_/nvidia/platform/t19x/jakku/kernel-dts/tegra194-p3668-all-p3509-0000.dtb -b 0 -i /home/pierre/Sources/linux-tegra-4.9/arch/arm64/boot/dts/../../../../nvidia/platform/t19 x/jakku/kernel-dts/ -i /home/pierre/Sources/linux-tegra-4.9/nvidia/soc/tegra/kernel-include -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/tegra/common/kernel-dts -i /home/pierre/So urces/linux-tegra-4.9/nvidia/soc/t210/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t210/common/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t210b0 1/common/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t210/porg/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t18x/kernel-include -i /home/pierre/Source s/linux-tegra-4.9/nvidia/soc/t18x/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t18x/common/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t19x/kernel-inc lude -i /home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t18x/kernel-include -i /home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t19x/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/ platform/t19x/common/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t23x/kernel-include -i /home/pierre/Sources/linux-tegra-4.9/nvidia/soc/t23x/kernel-dts -i /home/pierre/Sour ces/linux-tegra-4.9/nvidia/platform/t18x/lanai/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t18x/quill/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platfor m/t19x/galen/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/galen-industrial/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/jakku/kernel-dts -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/ -i /home/pierre/Sources/linux-tegra-4.9/nvidia/platform/t19x/mccoy/kernel-dts -Wno-unit_address_vs_reg -d arch/arm64/boot/dts/_ ddot_/_ddot_/_ddot_/_ddot_/nvidia/platform/t19x/jakku/kernel-dts/.tegra194-p3668-all-p3509-0000.dtb.d.dtc.tmp arch/arm64/boot/dts/_ddot_/_ddot_/_ddot_/_ddot_/nvidia/platform/t19x/jakku/kerne l-dts/.tegra194-p3668-all-p3509-0000.dtb.dts.tmp ; cat arch/arm64/boot/dts/_ddot_/_ddot_/_ddot_/_ddot_/nvidia/platform/t19x/jakku/kernel-dts/.tegra194-p3668-all-p3509-0000.dtb.d.pre.tmp arch /arm64/boot/dts/_ddot_/_ddot_/_ddot_/_ddot_/nvidia/platform/t19x/jakku/kernel-dts/.tegra194-p3668-all-p3509-0000.dtb.d.dtc.tmp > arch/arm64/boot/dts/_ddot_/_ddot_/_ddot_/_ddot_/nvidia/platfo rm/t19x/jakku/kernel-dts/.tegra194-p3668-all-p3509-0000.dtb.d

@madisongh
Copy link
Member

Are you saying you typed in that command manually (!), or is that an excerpt from running a bitbake build where you're trying to use devtool or externalsrc.bbclass (or just setting the SRC_REPO variable) to point the linux-tegra recipe at your local copy of the source tree? Did you already run through a full kernel build once, in the same workspace, before trying to recompile the device tree? Are you getting other error messages from that besides the one you mentioned in the OP? Does the kernel build succeed if you do a bitbake build and only fail with your manual command?

@pticon
Copy link
Author

pticon commented Aug 12, 2022

Hi @madisongh ,
It was an extract of the bitbake log with an external source with devtool.
The kernel and the modules can easily compiled and there is only error with the device tree tegra194-p3668-all-p3509-0000.dts.
What I see is that the file you pointed defines an alias named i2c7: tegra194-soc-i2c.dtsi#L30 but on the other side, the DTS uses it as a label: tegra194-camera-jakku-rbpcv3-imx477.dtsi#L30.
So I opened another thread in the nvidia forum here in order to sort this out.

@madisongh
Copy link
Member

I don't think that makes a difference - I'm certainly not seeing any error compiling the kernel and device tree for the Xavier NX, I've just verified that the stock device tree includes that dtsi file, and I can see the i2c-parent property in the compiled output.

Have you made any other changes in the device tree files?

madisongh pushed a commit that referenced this issue Jul 1, 2023
By keep sending L2CAP_CONF_REQ packets, chan->num_conf_rsp increases
multiple times and eventually it will wrap around the maximum number
(i.e., 255).
This patch prevents this by adding a boundary check with
L2CAP_MAX_CONF_RSP

Btmon log:
Bluetooth monitor ver 5.64
= Note: Linux version 6.1.0-rc2 (x86_64)                               0.264594
= Note: Bluetooth subsystem version 2.22                               0.264636
@ MGMT Open: btmon (privileged) version 1.22                  {0x0001} 0.272191
= New Index: 00:00:00:00:00:00 (Primary,Virtual,hci0)          [hci0] 13.877604
@ RAW Open: 9496 (privileged) version 2.22                   {0x0002} 13.890741
= Open Index: 00:00:00:00:00:00                                [hci0] 13.900426
(...)
> ACL Data RX: Handle 200 flags 0x00 dlen 1033             #32 [hci0] 14.273106
        invalid packet size (12 != 1033)
        08 00 01 00 02 01 04 00 01 10 ff ff              ............
> ACL Data RX: Handle 200 flags 0x00 dlen 1547             #33 [hci0] 14.273561
        invalid packet size (14 != 1547)
        0a 00 01 00 04 01 06 00 40 00 00 00 00 00        ........@.....
> ACL Data RX: Handle 200 flags 0x00 dlen 2061             #34 [hci0] 14.274390
        invalid packet size (16 != 2061)
        0c 00 01 00 04 01 08 00 40 00 00 00 00 00 00 04  ........@.......
> ACL Data RX: Handle 200 flags 0x00 dlen 2061             #35 [hci0] 14.274932
        invalid packet size (16 != 2061)
        0c 00 01 00 04 01 08 00 40 00 00 00 07 00 03 00  ........@.......
= bluetoothd: Bluetooth daemon 5.43                                   14.401828
> ACL Data RX: Handle 200 flags 0x00 dlen 1033             #36 [hci0] 14.275753
        invalid packet size (12 != 1033)
        08 00 01 00 04 01 04 00 40 00 00 00              ........@...

Bug 3819327

Change-Id: I3a3d497b5d549a89117491361aed22609f102e3d
Signed-off-by: Sungwoo Kim <[email protected]>
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-4.9/+/2823145
Reviewed-by: Dmitry Pervushin <[email protected]>
GVS: Gerrit_Virtual_Submit <[email protected]>
Tested-by: Dmitry Pervushin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants