Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export of observation analyses is restricted on domain #780

Open
MaximMoinat opened this issue Feb 11, 2025 · 0 comments
Open

Export of observation analyses is restricted on domain #780

MaximMoinat opened this issue Feb 11, 2025 · 0 comments

Comments

@MaximMoinat
Copy link
Contributor

Expected behavior

The OMOP CDM documentation user guide for the observation table states:

Valid Observation Concepts are not enforced to be from any domain but they must not belong to the Condition, Procedure, Drug, Device, Specimen, or Measurement domains and they must be Standard Concepts.
Therefor, the export of achilles results for the observation table should list all concepts except the ones listed above.

Observed behavior

Only concepts from the observation domain are exported, making others not visible in Atlas data sources and in Ares. This can be confusing as these records are simply hidden even if the OMOP CDM conventions are followed in the mapping.

Cause

The sqlObservationTable.sql and sqlObservationTreemap.sql have a filter on the observation domain.

Note that Atlas uses an adapted version of the Treemap query from the WebAPI results query, with a similar filter on the observation domain.

Proposed solution

Remove the filter on observation concept domain for these export queries.

@MaximMoinat MaximMoinat changed the title Export restricts observations on domain Export of observation analyses is restricted on domain Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant