Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication methods to support #105

Open
konstjar opened this issue Oct 21, 2024 · 3 comments
Open

Authentication methods to support #105

konstjar opened this issue Oct 21, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@konstjar
Copy link
Contributor

konstjar commented Oct 21, 2024

We need to get rid of Authenticator component and to switch to something generic like Spring Security.
There is a need to support the following authentication methods:

  • Local user (Local database). It will require user management (CRUD operations) through the UI.
  • OpenID Connect
  • SAML2
  • Google IAP
@konstjar konstjar added the enhancement New feature or request label Oct 21, 2024
@konstjar
Copy link
Contributor Author

@ablack3 Feel free to provide your input on this based on your knowledge.

@dmitrys-odysseus
Copy link
Contributor

As of spring-security 6.x, all the mentioned components are supported out of the box :
OpenID Connect - included in spring-security-oauth2-client / spring-security-oauth2-resource-server
SAML2 - Here are some examples
https://github.com/spring-projects/spring-security-samples/blob/main/servlet/spring-boot/java/saml2/custom-urls/README.adoc
The implementation looks quite advanced at a glance and supports proper logout.
IAP via spring-cloud-gcp-security-iap.
The latter is somewhat "nominal" implementation that needs some extra effort to be adapted to our case and so far I didn't spot any evidence it supports proper logout, but since IAP authentication is outside of the normal Authenticator API scope anyway, we are not taking a loss here.

Therefore, the target state is to use spring-security with standard extensions.

@anthonysena
Copy link
Contributor

Let's link this to OHDSI/AtlasWebAPIRoadmap#5 with the idea that we leverage the same capabilities across the OHDSI stack where possible.

@konstjar konstjar added this to the v2.0.5 milestone Nov 4, 2024
@konstjar konstjar modified the milestones: v2.0.5, v2.0.6 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants