Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the mechanism to keep the vocabulary list up to date #321

Open
TatianaSkugarevskaya opened this issue Dec 2, 2022 · 3 comments
Open

Comments

@TatianaSkugarevskaya
Copy link

Recently we have found out that there is a vocabulary in the Athena download list that has been deleted from the VOCABULARY table and deprecated in the concept (HGNC - Human Gene Nomenclature (European Bioinformatics Institute)). Since this is not supported any more, does not have concepts , it technically 'does not exist' in OMOP. It would be good to find an approach for keeping the Athena vocabulary list up-to-date.
HGNC
https://github.com/OHDSI/Vocabulary-v5.0/blob/5834f9f149f86598f26a8ee8724185d4fa55ed3d/working/manual_changes/2021/2021-10-20.sql#L1

@mik-ohdsi
Copy link

This is connected to this vocabulary issue - we have to remove this entry from the vocabulary_conversion table, which in turn is connected to #278 ....

@Alexdavv
Copy link
Member

Alexdavv commented Dec 9, 2022

we have to remove this entry from the vocabulary_conversion table

It was removed within the commit @TatianaSkugarevskaya is referring to.

@Alexdavv Alexdavv changed the title Keeping the vocabulary list up to date Create the mechanism to keep the vocabulary list up to date Dec 9, 2022
@mik-ohdsi
Copy link

to be precise, this is not an Athena issue but rather an issue on vocabulary maintenance, in which if there is not one concept for a given vocabulary ID on distribution to Athena, the vocabulary ID should be retired (deprecated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants