Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Line measurement value appears in basic mode but not microscopy #4758

Open
salimkanoun opened this issue Feb 1, 2025 · 5 comments
Open

Comments

@salimkanoun
Copy link
Contributor

Describe the Bug

Basic mode :

Image

Microscopy mode :

Image

The two lines doesn't have the same rendering and particularly the microscopy mode does not show the length measurement

Steps to Reproduce

  1. Go to https://viewer-dev.ohif.org/microscopy?StudyInstanceUIDs=2.25.141277760791347900862109212450152067508
  2. Draw a line in basic mode => length is shown
  3. Draw a line in microscopy mode => only the line itself is displayed without the lenght value

The current behavior

lenght in mm in microscpy mode is not displayed

The expected behavior

mm value shoudl be displayed

OS

linux

Node version

20

Browser

Chrome latest

@salimkanoun salimkanoun added the Awaiting Reproduction Can we reproduce the reported bug? label Feb 1, 2025
@salimkanoun
Copy link
Contributor Author

hum ok got it there is a difference between line and length so the icon is simply to be updated in microscpy mode

@sedghi
Copy link
Member

sedghi commented Feb 3, 2025

They are completely different things. The microscopy mode uses the line measurement in the DICOM microscopy viewer, while the basic viewer mode uses Cornerstone tools, pretty similar to other tools we have.

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Feb 3, 2025
@salimkanoun
Copy link
Contributor Author

Yeah but the icon is confusing

Image

It would be better to have this kind of icon to differentiate "line" from "measurement"

Image

@sedghi
Copy link
Member

sedghi commented Feb 3, 2025

viewer-dev does not show it, but the this one shows in the panel, so it is measuing

I know it is weird a lil bit

https://viewer.ohif.org/microscopy?StudyInstanceUIDs=2.25.141277760791347900862109212450152067508

@salimkanoun
Copy link
Contributor Author

I don't see any difference between viewer and viewer-dev

The difference I see is between

We have the same icon for two different tools that are not doing the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants