From 2aee2b8f6b6c2deab715ad83453a657371b14e0d Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Mon, 2 Mar 2026 21:20:09 +0100 Subject: [PATCH 1/3] detect/ftp: enable tests for 9 and further Tests were only run for main8 when they pass on 9 --- tests/detect-ftp/ftp-active-dynamic_port-01/test.yaml | 2 +- tests/detect-ftp/ftp-active-dynamic_port-02/test.yaml | 2 +- tests/detect-ftp/ftp-command-01/test.yaml | 2 +- tests/detect-ftp/ftp-command-02/test.yaml | 2 +- tests/detect-ftp/ftp-mode-01/test.yaml | 2 +- tests/detect-ftp/ftp-mode-02/test.yaml | 2 +- tests/detect-ftp/ftp-mode-03/test.yaml | 2 +- tests/detect-ftp/ftp-passive-dynamic_port-01/test.yaml | 2 +- tests/detect-ftp/ftp-passive-dynamic_port-02/test.yaml | 2 +- tests/detect-ftp/ftp-reply-received-01/test.yaml | 2 +- tests/detect-ftp/ftp-reply-received-02/test.yaml | 2 +- tests/detect-ftp/ftp-reply-received-03/test.yaml | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/detect-ftp/ftp-active-dynamic_port-01/test.yaml b/tests/detect-ftp/ftp-active-dynamic_port-01/test.yaml index 435d03d59..4483e09c7 100644 --- a/tests/detect-ftp/ftp-active-dynamic_port-01/test.yaml +++ b/tests/detect-ftp/ftp-active-dynamic_port-01/test.yaml @@ -1,7 +1,7 @@ pcap: ../../bug-3519/input.pcap requires: - version: 8 + min-version: 8 checks: diff --git a/tests/detect-ftp/ftp-active-dynamic_port-02/test.yaml b/tests/detect-ftp/ftp-active-dynamic_port-02/test.yaml index a3fe08054..aa0ef90ac 100644 --- a/tests/detect-ftp/ftp-active-dynamic_port-02/test.yaml +++ b/tests/detect-ftp/ftp-active-dynamic_port-02/test.yaml @@ -1,7 +1,7 @@ pcap: ftp-active-dynamic_port.pcap requires: - version: 8 + min-version: 8 args: - -k none diff --git a/tests/detect-ftp/ftp-command-01/test.yaml b/tests/detect-ftp/ftp-command-01/test.yaml index b5fd8058b..7a83d704b 100644 --- a/tests/detect-ftp/ftp-command-01/test.yaml +++ b/tests/detect-ftp/ftp-command-01/test.yaml @@ -1,7 +1,7 @@ pcap: ../../bug-3519/input.pcap requires: - version: 8 + min-version: 8 checks: diff --git a/tests/detect-ftp/ftp-command-02/test.yaml b/tests/detect-ftp/ftp-command-02/test.yaml index 688161dd2..aef13e30a 100644 --- a/tests/detect-ftp/ftp-command-02/test.yaml +++ b/tests/detect-ftp/ftp-command-02/test.yaml @@ -1,7 +1,7 @@ pcap: ../../bug-3519/input.pcap requires: - version: 8 + min-version: 8 exit-code: 1 diff --git a/tests/detect-ftp/ftp-mode-01/test.yaml b/tests/detect-ftp/ftp-mode-01/test.yaml index 191fb7443..b63bb9e9a 100644 --- a/tests/detect-ftp/ftp-mode-01/test.yaml +++ b/tests/detect-ftp/ftp-mode-01/test.yaml @@ -1,5 +1,5 @@ requires: - version: 8 + min-version: 8 pcap: ../../bug-3519/input.pcap diff --git a/tests/detect-ftp/ftp-mode-02/test.yaml b/tests/detect-ftp/ftp-mode-02/test.yaml index 0583a7998..a4cc88afc 100644 --- a/tests/detect-ftp/ftp-mode-02/test.yaml +++ b/tests/detect-ftp/ftp-mode-02/test.yaml @@ -1,5 +1,5 @@ requires: - version: 8 + min-version: 8 pcap: ../../ftp-epsv/input.pcap diff --git a/tests/detect-ftp/ftp-mode-03/test.yaml b/tests/detect-ftp/ftp-mode-03/test.yaml index af5086ddf..3a61f3003 100644 --- a/tests/detect-ftp/ftp-mode-03/test.yaml +++ b/tests/detect-ftp/ftp-mode-03/test.yaml @@ -1,5 +1,5 @@ requires: - version: 8 + min-version: 8 pcap: false exit-code: 1 diff --git a/tests/detect-ftp/ftp-passive-dynamic_port-01/test.yaml b/tests/detect-ftp/ftp-passive-dynamic_port-01/test.yaml index e6d25b2f5..575ecfbc5 100644 --- a/tests/detect-ftp/ftp-passive-dynamic_port-01/test.yaml +++ b/tests/detect-ftp/ftp-passive-dynamic_port-01/test.yaml @@ -1,7 +1,7 @@ pcap: ../../ftp-epsv/input.pcap requires: - version: 8 + min-version: 8 checks: diff --git a/tests/detect-ftp/ftp-passive-dynamic_port-02/test.yaml b/tests/detect-ftp/ftp-passive-dynamic_port-02/test.yaml index 85ccf5924..6c69c9c72 100644 --- a/tests/detect-ftp/ftp-passive-dynamic_port-02/test.yaml +++ b/tests/detect-ftp/ftp-passive-dynamic_port-02/test.yaml @@ -1,7 +1,7 @@ pcap: ftp-passive-dynamic_port.pcap requires: - version: 8 + min-version: 8 checks: diff --git a/tests/detect-ftp/ftp-reply-received-01/test.yaml b/tests/detect-ftp/ftp-reply-received-01/test.yaml index 999d8a54c..61d3fed97 100644 --- a/tests/detect-ftp/ftp-reply-received-01/test.yaml +++ b/tests/detect-ftp/ftp-reply-received-01/test.yaml @@ -1,5 +1,5 @@ requires: - version: 8 + min-version: 8 pcap: ../../bug-3519/input.pcap diff --git a/tests/detect-ftp/ftp-reply-received-02/test.yaml b/tests/detect-ftp/ftp-reply-received-02/test.yaml index fac9dc4c7..873605928 100644 --- a/tests/detect-ftp/ftp-reply-received-02/test.yaml +++ b/tests/detect-ftp/ftp-reply-received-02/test.yaml @@ -1,5 +1,5 @@ requires: - version: 8 + min-version: 8 pcap: ../../ftp/ftp-too-long-response/ftp-too-long-response.pcap diff --git a/tests/detect-ftp/ftp-reply-received-03/test.yaml b/tests/detect-ftp/ftp-reply-received-03/test.yaml index 56efdc15c..c5515291c 100644 --- a/tests/detect-ftp/ftp-reply-received-03/test.yaml +++ b/tests/detect-ftp/ftp-reply-received-03/test.yaml @@ -1,5 +1,5 @@ requires: - version: 8 + min-version: 8 pcap: false exit-code: 1 From fd20e356f4dde34be2e3ea30a1d611533a4d4d2f Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Mon, 2 Mar 2026 21:21:26 +0100 Subject: [PATCH 2/3] pop3: enable test for 9 and further Test was only run for main8 when they pass on 9 --- tests/pop3-auth-01/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/pop3-auth-01/test.yaml b/tests/pop3-auth-01/test.yaml index 06c0cedb0..b7a1e0f6a 100644 --- a/tests/pop3-auth-01/test.yaml +++ b/tests/pop3-auth-01/test.yaml @@ -1,5 +1,5 @@ requires: - version: 8 + min-version: 8 args: - -k none From 281af7f3f6a9122756fa7cba13cfd2c70eba42f1 Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Mon, 2 Mar 2026 21:25:13 +0100 Subject: [PATCH 3/3] udp: enable tests for 8, 9 and further Tests were only run for main7 when they pass on 9 Ticket: 5379 --- tests/udp-5379/udp-hlen-invalid-non-strict/test.yaml | 1 - tests/udp-5379/udp-hlen-invalid-strict/test.yaml | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/udp-5379/udp-hlen-invalid-non-strict/test.yaml b/tests/udp-5379/udp-hlen-invalid-non-strict/test.yaml index 382f235ad..198f94f99 100644 --- a/tests/udp-5379/udp-hlen-invalid-non-strict/test.yaml +++ b/tests/udp-5379/udp-hlen-invalid-non-strict/test.yaml @@ -10,7 +10,6 @@ command: | checks: - shell: - version: 7 args: |- grep "Warning: detect: decode-event keyword no longer supports event \"decoder.udp.hlen_invalid\"" suricata.log | wc -l expect: 1 diff --git a/tests/udp-5379/udp-hlen-invalid-strict/test.yaml b/tests/udp-5379/udp-hlen-invalid-strict/test.yaml index fed9fc304..28749fe11 100644 --- a/tests/udp-5379/udp-hlen-invalid-strict/test.yaml +++ b/tests/udp-5379/udp-hlen-invalid-strict/test.yaml @@ -9,7 +9,6 @@ command: | checks: - shell: - version: 7 args: |- grep "Error: detect: decode-event keyword no longer supports event \"decoder.udp.hlen_invalid\"" suricata.log | wc -l expect: 1