diff --git a/rust/src/krb/log.rs b/rust/src/krb/log.rs index 427876ad7e3c..7cb952581bc7 100644 --- a/rust/src/krb/log.rs +++ b/rust/src/krb/log.rs @@ -18,7 +18,7 @@ // written by Pierre Chifflier use crate::jsonbuilder::{JsonBuilder, JsonError}; -use crate::krb::krb5::{KRB5State,KRB5Transaction,test_weak_encryption}; +use crate::krb::krb5::{KRB5Transaction,test_weak_encryption}; fn krb5_log_response(jsb: &mut JsonBuilder, tx: &mut KRB5Transaction) -> Result<(), JsonError> { @@ -68,7 +68,7 @@ fn krb5_log_response(jsb: &mut JsonBuilder, tx: &mut KRB5Transaction) -> Result< } #[no_mangle] -pub extern "C" fn rs_krb5_log_json_response(jsb: &mut JsonBuilder, _state: &mut KRB5State, tx: &mut KRB5Transaction) -> bool +pub extern "C" fn rs_krb5_log_json_response(jsb: &mut JsonBuilder, tx: &mut KRB5Transaction) -> bool { krb5_log_response(jsb, tx).is_ok() } diff --git a/rust/src/mqtt/logger.rs b/rust/src/mqtt/logger.rs index 09b14fe25d6f..af0db17bc2b8 100644 --- a/rust/src/mqtt/logger.rs +++ b/rust/src/mqtt/logger.rs @@ -17,7 +17,7 @@ // written by Sascha Steinbiss -use super::mqtt::{MQTTState, MQTTTransaction}; +use super::mqtt::MQTTTransaction; use crate::jsonbuilder::{JsonBuilder, JsonError}; use crate::mqtt::mqtt_message::{MQTTOperation, MQTTSubscribeTopicData}; use crate::mqtt::parser::FixedHeader; @@ -298,7 +298,7 @@ fn log_mqtt(tx: &MQTTTransaction, flags: u32, js: &mut JsonBuilder) -> Result<() #[no_mangle] pub unsafe extern "C" fn rs_mqtt_logger_log( - _state: &mut MQTTState, tx: *mut std::os::raw::c_void, flags: u32, js: &mut JsonBuilder, + tx: *mut std::os::raw::c_void, flags: u32, js: &mut JsonBuilder, ) -> bool { let tx = cast_pointer!(tx, MQTTTransaction); log_mqtt(tx, flags, js).is_ok() diff --git a/rust/src/rfb/logger.rs b/rust/src/rfb/logger.rs index e670e869cec3..392b825b19d3 100644 --- a/rust/src/rfb/logger.rs +++ b/rust/src/rfb/logger.rs @@ -19,7 +19,7 @@ use std; use std::fmt::Write; -use super::rfb::{RFBState, RFBTransaction}; +use super::rfb::RFBTransaction; use crate::jsonbuilder::{JsonBuilder, JsonError}; fn log_rfb(tx: &RFBTransaction, js: &mut JsonBuilder) -> Result<(), JsonError> { @@ -113,8 +113,7 @@ fn log_rfb(tx: &RFBTransaction, js: &mut JsonBuilder) -> Result<(), JsonError> { } #[no_mangle] -pub unsafe extern "C" fn rs_rfb_logger_log(_state: &mut RFBState, - tx: *mut std::os::raw::c_void, +pub unsafe extern "C" fn rs_rfb_logger_log(tx: *mut std::os::raw::c_void, js: &mut JsonBuilder) -> bool { let tx = cast_pointer!(tx, RFBTransaction); log_rfb(tx, js).is_ok() diff --git a/src/output-json-alert.c b/src/output-json-alert.c index f7b67fa0c082..d7918e81ffaa 100644 --- a/src/output-json-alert.c +++ b/src/output-json-alert.c @@ -229,12 +229,12 @@ static void AlertJsonDns(const Flow *f, const uint64_t tx_id, JsonBuilder *js) dns_state, tx_id); if (txptr) { jb_open_object(js, "dns"); - JsonBuilder *qjs = JsonDNSLogQuery(txptr, tx_id); + JsonBuilder *qjs = JsonDNSLogQuery(txptr); if (qjs != NULL) { jb_set_object(js, "query", qjs); jb_free(qjs); } - JsonBuilder *ajs = JsonDNSLogAnswer(txptr, tx_id); + JsonBuilder *ajs = JsonDNSLogAnswer(txptr); if (ajs != NULL) { jb_set_object(js, "answer", ajs); jb_free(ajs); diff --git a/src/output-json-dns.c b/src/output-json-dns.c index d5729c85961c..0b6589d5c1bf 100644 --- a/src/output-json-dns.c +++ b/src/output-json-dns.c @@ -263,7 +263,7 @@ typedef struct LogDnsLogThread_ { OutputJsonThreadCtx *ctx; } LogDnsLogThread; -JsonBuilder *JsonDNSLogQuery(void *txptr, uint64_t tx_id) +JsonBuilder *JsonDNSLogQuery(void *txptr) { JsonBuilder *queryjb = jb_new_array(); if (queryjb == NULL) { @@ -292,7 +292,7 @@ JsonBuilder *JsonDNSLogQuery(void *txptr, uint64_t tx_id) return queryjb; } -JsonBuilder *JsonDNSLogAnswer(void *txptr, uint64_t tx_id) +JsonBuilder *JsonDNSLogAnswer(void *txptr) { if (!rs_dns_do_log_answer(txptr, LOG_ALL_RRTYPES)) { return NULL; diff --git a/src/output-json-dns.h b/src/output-json-dns.h index 9d0e451328e3..1e19427361b8 100644 --- a/src/output-json-dns.h +++ b/src/output-json-dns.h @@ -26,7 +26,7 @@ void JsonDnsLogRegister(void); -JsonBuilder *JsonDNSLogQuery(void *txptr, uint64_t tx_id) __attribute__((nonnull)); -JsonBuilder *JsonDNSLogAnswer(void *txptr, uint64_t tx_id) __attribute__((nonnull)); +JsonBuilder *JsonDNSLogQuery(void *txptr) __attribute__((nonnull)); +JsonBuilder *JsonDNSLogAnswer(void *txptr) __attribute__((nonnull)); #endif /* __OUTPUT_JSON_DNS_H__ */ diff --git a/src/output-json-ftp.c b/src/output-json-ftp.c index 7177fb6a9dbc..ece9344bf409 100644 --- a/src/output-json-ftp.c +++ b/src/output-json-ftp.c @@ -46,7 +46,7 @@ #include "app-layer-ftp.h" #include "output-json-ftp.h" -static void EveFTPLogCommand(Flow *f, FTPTransaction *tx, JsonBuilder *jb) +static void EveFTPLogCommand(FTPTransaction *tx, JsonBuilder *jb) { /* Preallocate array objects to simplify failure case */ JsonBuilder *js_resplist = NULL; @@ -173,7 +173,7 @@ static int JsonFTPLogger(ThreadVars *tv, void *thread_data, if (f->alproto == ALPROTO_FTPDATA) { EveFTPDataAddMetadata(f, jb); } else { - EveFTPLogCommand(f, tx, jb); + EveFTPLogCommand(tx, jb); } if (!jb_close(jb)) { diff --git a/src/output-json-krb5.c b/src/output-json-krb5.c index 8381cfd6132f..5e6fbad5ecd1 100644 --- a/src/output-json-krb5.c +++ b/src/output-json-krb5.c @@ -60,7 +60,7 @@ static int JsonKRB5Logger(ThreadVars *tv, void *thread_data, } jb_open_object(jb, "krb5"); - if (!rs_krb5_log_json_response(jb, state, krb5tx)) { + if (!rs_krb5_log_json_response(jb, krb5tx)) { goto error; } jb_close(jb); diff --git a/src/output-json-mqtt.c b/src/output-json-mqtt.c index 7b3ca62131ac..9ea890508070 100644 --- a/src/output-json-mqtt.c +++ b/src/output-json-mqtt.c @@ -65,7 +65,7 @@ bool JsonMQTTAddMetadata(const Flow *f, uint64_t tx_id, JsonBuilder *js) if (state) { MQTTTransaction *tx = AppLayerParserGetTx(f->proto, ALPROTO_MQTT, state, tx_id); if (tx) { - return rs_mqtt_logger_log(state, tx, MQTT_DEFAULTS, js); + return rs_mqtt_logger_log(tx, MQTT_DEFAULTS, js); } } @@ -89,7 +89,7 @@ static int JsonMQTTLogger(ThreadVars *tv, void *thread_data, return TM_ECODE_FAILED; } - if (!rs_mqtt_logger_log(state, tx, thread->mqttlog_ctx->flags, js)) + if (!rs_mqtt_logger_log(tx, thread->mqttlog_ctx->flags, js)) goto error; OutputJsonBuilderBuffer(js, thread->ctx); diff --git a/src/output-json-rfb.c b/src/output-json-rfb.c index 285c22ab4482..cc12d2f1bbdc 100644 --- a/src/output-json-rfb.c +++ b/src/output-json-rfb.c @@ -48,11 +48,11 @@ bool JsonRFBAddMetadata(const Flow *f, uint64_t tx_id, JsonBuilder *js) { - RFBState *state = FlowGetAppState(f); + void *state = FlowGetAppState(f); if (state) { RFBTransaction *tx = AppLayerParserGetTx(f->proto, ALPROTO_RFB, state, tx_id); if (tx) { - return rs_rfb_logger_log(state, tx, js); + return rs_rfb_logger_log(tx, js); } } @@ -69,7 +69,7 @@ static int JsonRFBLogger(ThreadVars *tv, void *thread_data, return TM_ECODE_FAILED; } - if (!rs_rfb_logger_log(NULL, tx, js)) { + if (!rs_rfb_logger_log(tx, js)) { goto error; } diff --git a/src/output-json-smtp.c b/src/output-json-smtp.c index 99771ec68fb4..cc3003907585 100644 --- a/src/output-json-smtp.c +++ b/src/output-json-smtp.c @@ -51,7 +51,7 @@ #include "output-json-smtp.h" #include "output-json-email-common.h" -static void EveSmtpDataLogger(const Flow *f, void *state, void *vtx, uint64_t tx_id, JsonBuilder *js) +static void EveSmtpDataLogger(void *state, void *vtx, JsonBuilder *js) { SMTPTransaction *tx = vtx; SMTPString *rcptto_str; @@ -81,7 +81,7 @@ static int JsonSmtpLogger(ThreadVars *tv, void *thread_data, const Packet *p, Fl return TM_ECODE_OK; jb_open_object(jb, "smtp"); - EveSmtpDataLogger(f, state, tx, tx_id, jb); + EveSmtpDataLogger(state, tx, jb); jb_close(jb); EveEmailLogJson(jhl, jb, p, f, state, tx, tx_id); @@ -99,7 +99,7 @@ bool EveSMTPAddMetadata(const Flow *f, uint64_t tx_id, JsonBuilder *js) if (smtp_state) { SMTPTransaction *tx = AppLayerParserGetTx(IPPROTO_TCP, ALPROTO_SMTP, smtp_state, tx_id); if (tx) { - EveSmtpDataLogger(f, smtp_state, tx, tx_id, js); + EveSmtpDataLogger(smtp_state, tx, js); return true; } }