Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nearshop Logistic Seller (LSP) - Compliance Check #3088

Open
sharique827 opened this issue Jan 13, 2025 · 6 comments
Open

Nearshop Logistic Seller (LSP) - Compliance Check #3088

sharique827 opened this issue Jan 13, 2025 · 6 comments

Comments

@sharique827
Copy link

Happy flow

"/on_confirm"

  • range object is missing inside start/range in fulfillment.
  • time object is missing inside end object in fulfillment.

RTO flow

"/on_confirm"

  • range object is missing inside start/range in fulfillment.
  • time object is missing inside end object in fulfillment.
  • message/order/tags bpp_terms should be as per API contract.

"/on_cancel"

  • "timestamp is missing in start/time/timestamp in fulfillment type "Delivery".
  • "RTO fulfillment is missing.
  • "RTO object is missing in quote/breakup.

"/on_status"

  • in rto delivered on_status call, "timestamp is missing in start/time/timestamp in fulfillment type "Delivery".
  • "RTO fulfillment is missing.
  • "RTO object is missing in quote/breakup.

TAT breach flow

"/on_confirm"

  • range object is missing inside start/range in fulfillment.
  • time object is missing inside end object in fulfillment.
  • message/order/tags bpp_termsshould be as per API contract.

"/on_cancel"

  • message/order/cancellation/reason/id must be equal to one of the allowed values (008,011,012,013,014,015,016,017,020,021,997)",

@sudhakara11

@sudhakara11
Copy link
Contributor

Dear @sharique827 @abhinavv245

We have fixed the observations and submitted the with below PR link.

#3108

@RonitKumarSinha

Regards,
Sudhakar G

@sharique827
Copy link
Author

Common Issue

  • when ready_to_ship is 'no' in /confirm, how is this changed to 'yes' in /on_confirm

RTO Flow

  • /on_status_rto_delivered

    • In the on_status_rto_delivered call, the RTO fulfillment state should be rto_delivered instead of rto_initiated.
    • In the on_status_rto_delivered call, timestamp is missing in the end object where the fulfillment type is rto.
  • /on_cancel_rto_initiated

    • Message.order.fulfillments[1].end.time and start.time.range are incorrect.

@sudhakara11

@sudhakara11
Copy link
Contributor

@sharique827

The issues has been fixed with below PR link

#3123

Regards,
Sudhakar G

@RonitKumarSinha

@abhinavv245
Copy link
Collaborator

abhinavv245 commented Jan 23, 2025

@sudhakara11

/on_confirm

  • why time/range is provided in both start and end object while ready to ship is no (need not be provided)

/cancel (TAT breach)

  • invalid cancellation reason code by LBNP.

/on_cancel

  • cancellation/cancelled_by should have the subscriber_id of the NP cancelling the order.
  • howcome RTO delivered on_status call sent before RTO was initiated in /on_cancel?

Note: You may submit only the cancellation flows.

@sudhakara11
Copy link
Contributor

Dear @abhinavv245

The issues have been fixed with the below PR

#3141

Regards,
Sudhakar G

@RonitKumarSinha

@abhinavv245
Copy link
Collaborator

Logs approved for v1.2.

@sudhakara11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants