Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiranaPro (BA: RET10 - Compliance Check) #3198

Closed
Jagannath-wits opened this issue Feb 3, 2025 · 3 comments
Closed

KiranaPro (BA: RET10 - Compliance Check) #3198

Jagannath-wits opened this issue Feb 3, 2025 · 3 comments

Comments

@Jagannath-wits
Copy link
Collaborator

Kirana pro

Buyer app must Nack for the following seller issues

Flow 1

On_search

  • Are variants supported by buyer app?
  • return_window should not be P0D as it also serves as igm window.
  • category_id Cleaning & Household has been deprecated. Please refer to this link
  • either @ondc/org/statutory_reqs_prepackaged_food or @ondc/org/statutory_reqs_packaged_commodities is required for an item; not both.

On_search_inc

  • Available.count should either be 0 or 99 as these are enums

Flow 2

on_select

  • available/count available count must be either 99 or 0 only

on_init

  • provider_tax_number must be present for on_init

on_status_picked

  • message/order must have ‘documents’ from on_status_picked onwards for invoice
  • Mismatch occurred while comparing 'Delivery' fulfillment object with on_status_pending on key 'end/contact’ i.e email is missing, audit trail must be mantained.

Flow 3

  • It must follow the flow 3 of rollout plan i.e multiple items must be selected put of which one item will be out of stock and the same cart continues the journey
    Link to Rollout Plan

Flow 4

on_cancel

  • precancel_state.updated_at of on_cancel is not equal with the on_confirm order.updated_at

Flow 5

on_cancel_rto

  • precancel_state.updated_at of on_status_rto_delivered/disposed is not equal with the on_status_out_for_delivery order.updated_at

Flow 6

on_update

  • Message id should not be same with previous calls for unsolicited calls

Liquidation scenario is missing

Flow 7

catalog rejection

  • Errors.path not captured properly; it should be like message.catalog.bpp/providers[?(@.id=='P1')].items[?(@.id=='I1’)] . Please refer to this doc
  • Incorrect error Item price > MRP for items as the value is less than maximum_value i.e correct. Please recheck the validations.

@vanshraghav

@Jagannath-wits
Copy link
Collaborator Author

Jagannath-wits commented Feb 5, 2025

KiranaPro Pramaan logs

Buyer-app must add validation and Nack for the following seller issues

Flow 3A

on_status

  • Cancellation reason code 016 is not applicable for partial cancellation.
  • Quote price should also be decreased as one item got cancelled.

Flow 3B

on_status

  • Cancellation reason code 015 is not valid (merged with 013) and is not applicable for partial cancellation.
  • fulfillments.end.timestamp is missing.

Flow 4B

on_status

  • Audit trail should be maintained (extra item added).

@vanshraghav please add validation for broken audit-trail and above mentioned issues


Pramaan Issues

Flow 1A

on_select1

  • Price value should be accurate up to two decimal places.

on_init1

  • cancellation_terms.refund_eligible and reason_required are not required (refer to API contract).

  • cancellation_fee should not have a separate object for amount.

    "cancellation_fee": {
      "percentage": "35.00",
      "amount": {
        "currency": "INR",
        "value": "0.00"
      }
    },
    "amount": {
      "currency": "INR",
      "value": "50.75"
    }
    

Flow 5

on_select (Out of Stock)

  • Why is the delivery and convenience fee charged when the item is out of stock?

Flow 8

on_search

  • bpp/provider.location.circle radius can not exceed 500km max

@vanshraghav
Copy link
Contributor

vanshraghav commented Feb 11, 2025

Hi @Jagannath-wits ,

Variants support is there but the seller doesn't have support for variants . If you want I am sharing the payload from a seller which has variants https://we.tl/t-qZsjLJJqXYhttps://we.tl/t-qZsjLJJqXY

@Jagannath-wits
Copy link
Collaborator Author

@vanshraghav Logs approved for KiranaPro (BA: RET10 ); subject to above fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants