Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cache isn't validated nor pregenerated for use #140

Open
GigiaJ opened this issue Mar 17, 2022 · 2 comments
Open

[BUG] Cache isn't validated nor pregenerated for use #140

GigiaJ opened this issue Mar 17, 2022 · 2 comments
Assignees
@GigiaJ
Labels
bug Denotes that this a bug critical urgent or causing complete failure in entire program (crashing or looping) imperative imperitive, needs to be done immediately

Comments

@GigiaJ
Copy link
Collaborator

GigiaJ commented Mar 17, 2022

BEFORE REPORTING
Ensure RuneLite is up to date in IDE and you are using the latest version of the master branch

Describe the bug
Currently, the cache loading has no verification. It is on my TODO, but as of now, it is a bug waiting to occur. If OSRS updates it will never attempt to refresh the cache and just uses the version it was first installed to run on. But worse than this, if RuneLite has never been ran then the jagexcache has never been generated, and thus the client will fail to launch entirely.

To Reproduce
Steps to reproduce the behavior:

  1. Run the client without ever having ran RuneLite

  2. Profit

  3. Run the client with an old version of OSRS having been loaded into the cache by RuneLite

  4. Next update the cache is now out of date on our end

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]

Additional context
Yeah, yeah I'll be the one to fix it, but this is for documentation purposes.
@GigiaJ GigiaJ added critical urgent or causing complete failure in entire program (crashing or looping) bug Denotes that this a bug imperative imperitive, needs to be done immediately labels Mar 17, 2022
@GigiaJ GigiaJ self-assigned this Mar 17, 2022
@GigiaJ
Copy link
Collaborator Author

GigiaJ commented Mar 17, 2022

A current workaround is a manual deletion of your cache when necessary and running a RuneLite run mode to generate the Jagex Cache.

@GigiaJ
Copy link
Collaborator Author

GigiaJ commented Jun 30, 2022

Pre-generation is now fixed.
Version checking still needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GigiaJ GigiaJ

Labels
bug Denotes that this a bug critical urgent or causing complete failure in entire program (crashing or looping) imperative imperitive, needs to be done immediately
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GigiaJ