Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUGGESTION] Equipment .vs Inventory signature irregularity with containsOneOf #244

Open
analtevs opened this issue Nov 18, 2022 · 3 comments
Open

[SUGGESTION] Equipment .vs Inventory signature irregularity with containsOneOf #244

analtevs opened this issue Nov 18, 2022 · 3 comments

Comments

@analtevs
Copy link

Equipment:

public boolean containsOneOf(int... items)

Inventory:

public boolean containsOneOf(final Integer... itemID)

not a huge deal here but i think we should have matching sigs across the board.
@GigiaJ
Copy link
Collaborator

GigiaJ commented Nov 18, 2022

Yeah, I agree. Consistency is pretty important in any API. I think it got changed a little while back from a PR.

@analtevs
Copy link
Author

i'd be happy to identify a few more changes needed (provided its not going to annoy anyone)

@GigiaJ
Copy link
Collaborator

GigiaJ commented Nov 18, 2022

Feel free. It won't bother me. I absolutely welcome any contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GigiaJ @analtevs