Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toleration specified in value file not applied for Operator #165

Open
Jaryllan opened this issue Oct 16, 2023 · 5 comments
Open

Toleration specified in value file not applied for Operator #165

Jaryllan opened this issue Oct 16, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Jaryllan
Copy link

Jaryllan commented Oct 16, 2023

Does this issue reproduce with the latest release?
Yes

What operating system and processor architecture are you using (kubectl version)?
Client Version: v1.28.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.2

What did you do?
helm upgrade redis-operator ot-helm/redis-operator --install --namespace ot-operators --values values-operator.yaml --create-namespace

values-operator.yaml content

tolerations:
  - effect: NoSchedule
    key: node-role.kubernetes.io/control-plane
    operator: Exists
nodeSelector:
  node-role.kubernetes.io/control-plane:

What did you expect to see?
Toleration applied.

What did you see instead?
Toleration not included.

Based on the value template. https://github.com/OT-CONTAINER-KIT/helm-charts/blob/main/charts/redis-operator/values.yaml. It was suppose to be supported to supply toleration, but upon installing the operator, the toleration is not included

@Jaryllan Jaryllan added the bug Something isn't working label Oct 16, 2023
@artyom-p
Copy link

artyom-p commented Nov 7, 2023

Facing exactly the same issue now

@mrhovunping
Copy link

mrhovunping commented Nov 24, 2023

Facing also the same problem:
operator-deployment.yaml is missing code to include tolerations defined in values.yml.

We should have a section like:

  • tolerations: {{ toYaml . | nindent 8 }} {{- end }}

@dpujadas
Copy link

The problem with tolerations prevents us from using the chart. What else is needed to approve the PR and solve this issue?

@lucasbrazi666
Copy link

Any news to solve this issue will be well appreciated!
Thanks!

@MFomichev
Copy link

Any news about PR? We are looking forward to see it in upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants