Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to EJS #157

Open
9 tasks
UlisesGascon opened this issue Aug 6, 2019 · 4 comments
Open
9 tasks

Migration to EJS #157

UlisesGascon opened this issue Aug 6, 2019 · 4 comments

Comments

@UlisesGascon
Copy link
Collaborator

UlisesGascon commented Aug 6, 2019

Context

Tasks

  • Remove dependency Swig in package.json
  • Add dependency ejs in package.json
  • Configure express to use ejs as template engine
  • migrate all the files from /app/views/**.html to EJS
  • Validate the instalation with the local test
  • Add and submit the changes in package-lock.json
  • Add the primary depdency list to the readme.md
  • Check that the npm tasks are working as expected
  • Update the readme.md with the extra relevant info (if needed)

Assignation

  • This tasks is open for assignation, just claim it (as reply to this) and submit your PR ;-)

Important

@flippedcoder
Copy link

flippedcoder commented Aug 16, 2019

Hi there! I'd like to work on this issue. When do you need this finished?

@UlisesGascon
Copy link
Collaborator Author

Hi @flippedcoder!

Super welcome aboard. There is no deadline or pressure for this issue, so you can work on it quietly 😄

I just assigned this issue to you. Please send the PR against branch version-1.5 😉.

If you have more questions.. please, ping me ^^

@flippedcoder
Copy link

@UlisesGascon Just a quick update, I've gotten the migration over to ejs finished! I'm going through and fixing all of the errors from npm run precommit. I should have a PR up for this some time next week.

@flippedcoder
Copy link

Looks like this got closed with #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants