Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors field is not saved #935

Open
kostasadriano opened this issue Apr 3, 2024 · 4 comments
Open

Contributors field is not saved #935

kostasadriano opened this issue Apr 3, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation priority version-2.3

Comments

@kostasadriano
Copy link
Collaborator

Describe the bug:
Contributors field is not saved

Expected behaviour:
After adding contributors and saving the model, the relevant field should appear as filled.

Environment:

  • Version: 2.2.0
  • Platform: Desktop App
  • OS: Tested on Windows, could affect Linux as well

To Reproduce:

  1. Added Contributors
  2. Clicked Save
  3. Successfully saved message appeared
    1. When we close the screen and return to the main model page, we do not see the contributors. If we edit it again, the field now is empty as well.

Any additional context, screenshots, etc:
Threat Dragon_contributors not saved_1
Threat Dragon_contributors not saved_2

@kostasadriano kostasadriano added the bug Something isn't working label Apr 3, 2024
@jgadsden jgadsden added documentation Improvements or additions to documentation version-2.3 and removed bug Something isn't working labels Apr 3, 2024
@jgadsden
Copy link
Collaborator

jgadsden commented Apr 3, 2024

Hello @kostasadriano , thanks for raising this. It is a feature of Threat Dragon that you have to click the 'Add' button to enter the contributor - this allows for a list of contributors to be built up, rather than a single text string:
Screenshot 2024-04-03 at 22 02 14

@jgadsden
Copy link
Collaborator

jgadsden commented Apr 3, 2024

It may be that the documentation is not clear here, so marking this issue as Documentation for next release

@kostasadriano
Copy link
Collaborator Author

It was right in front of my eyes!
Maybe the button is a bit far away and greyed.
The most possible explanation though, is that the button appears only after you have added names, so before adding them I thought that the field worked like the owner and reviewer. Having it from the beginning would make it more clear.

@jgadsden
Copy link
Collaborator

jgadsden commented Apr 4, 2024

yes, I agree @kostasadriano , it certainly can be improved - it is just finding someone with the time to do it :)
we can update the documentation until it can be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority version-2.3
Projects
None yet
Development

No branches or pull requests

2 participants