Revise contributing guidelines

[johcarter]

Description

The contributing guidelines (CONTRIBUTING.md) in the repo are for OasisLMF code contributions and not really suitable for data standard contributions and proposals. Needs revising.

[aiste-kalinauskaite]

@johcarter could you add a link where the current ones are? And when the proposal is available, add it here please.

[johcarter]

Hi @aiste-kalinauskaite here we are:
Current: https://github.com/OasisLMF/ODS_OpenExposureData/blob/develop/CONTRIBUTING.md
Proposed: https://github.com/OasisLMF/ODS_OpenExposureData/blob/contributions/CONTRIBUTING.md

[johcarter]

Also see PR for first mapping contribution
#234

[aiste-kalinauskaite]

@johcarter
proposal looks much more aligned to OED, so would be a good way forward.
One exception is that "occupancy, construction and geography schemes, and code mappings" should be part of the OED versioning, as otherwise, any validation is impossible. Currently, if a model vendor supports version x.y.z, then we know exactly which codes are valid and which are not. If those codes are excluded from versions and can be changed at any moment in time, there is no way to keep track or know what exactly is supported and what is valid for a particular OED version.

[johcarter]

Hi @aiste-kalinauskaite , i think accepting other codelists as part of the specification itself + ODS tools validation is a big increase in scope and would require alot more resources to maintain it. I think this is therefore a SteerCo decision. For now, I suggest updating CONTRIBUTING.md only, but without the part about other data schemes/ mappings until we make a decision on this. I can backlog the first mapping contribution as there is no rush to put this into 4.0.0.

[johcarter]

New version of contributing guidelines here
@aiste-kalinauskaite @MattDonovan82 https://github.com/OasisLMF/ODS_OpenExposureData/blob/contributions2/CONTRIBUTING.md
PR: #235
would appreciate a quick turnaround if possible please

[MattDonovan82]

@johcarter It looks good to me. The only question I have is the reference or link to the .xlsx specification doc. Is this still going to be auto generated from the csv's? If so, this may want to be mentioned.

Everything else looks.

[aiste-kalinauskaite]

@johcarter contributing guides look ok to me.