Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign model and analys settings schema with actual options for correlation settings #118

Closed
fl-ndaq opened this issue Jun 5, 2024 · 3 comments · Fixed by #122
Closed
Assignees
Milestone

Comments

@fl-ndaq
Copy link
Contributor

fl-ndaq commented Jun 5, 2024

Issue Description

Correlation settings in both model and analysis settings schemas only allow parameter correlation_value whereas code expects at least one of hazard_correlation_value and damage_correlation_value

damage_group_fields and hazard_group_fields could also be moved from the model settings data_settings object to model_settings in order to expose them to users.

@benhayes21 benhayes21 self-assigned this Jun 6, 2024
@benhayes21 benhayes21 moved this from Todo to Waiting for Review in Oasis Dev Team Tasks Jun 26, 2024
@sambles sambles linked a pull request Jun 26, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Waiting for Review to Done in Oasis Dev Team Tasks Jun 26, 2024
@awsbuild awsbuild added this to the 3.2.5 milestone Jul 1, 2024
@fl-ndaq
Copy link
Contributor Author

fl-ndaq commented Jul 8, 2024

@benhayes21 model_settings.json schema also needs to be aligned. please make sure this is going in 3.2.6

@benhayes21
Copy link
Contributor

I think the first bit has already been done. The group fields not so though.

@fl-ndaq
Copy link
Contributor Author

fl-ndaq commented Jul 16, 2024

@benhayes21 What's missing then? aside from the damage_group_fields and hazard_group_fields instead of correlation_value in model_settings schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants