Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformation tool: OEDVersion is incorrect in OED location output #154

Open
niamhomalleyjba opened this issue Oct 29, 2024 · 0 comments
Open
Assignees

Comments

@niamhomalleyjba
Copy link

Issue Description

The OEDVersion present in the OED location file that is output is incorrect. If 3.0.2 is input in the config file, the output csv contains 302

Steps to Reproduce (Bugs only)

Config file:

transformations:
  loc: # Transformation name
    input_format:
      name: Cede_Location
      version: 10.0.0
    output_format:
      name: OED_Location
      version: 3.0.2
    runner:
      batch_size: 750 # Number of rows to process in a single batch
    extractor:
      type: mssql # Path to the DB connection file. Other options are 'postgres' and 'sqlite'. Defaults to 'csv', when not present.
      options:
        host: myserver, 1450
        port:
        database: MY_DB
        user: foo
        password: bar
        sql_statement: ./cede_location.sql # SQL statement to extract data
    loader:
      options:
        path: ./oed_location.csv # Path to the output file
        quoting: minimal

Command used:

ods_tools transform --config-file /path/to/config.yaml --nocheck

Output is created but the OEDVersion present in the oed_location.csv is 302, rather than the 3.0.2 detailed in the config.

Version / Environment information

Name: ods_tools
Version: 3.2.7

Example data / logs

@benhayes21 benhayes21 self-assigned this Nov 20, 2024
@benhayes21 benhayes21 moved this to In Progress in Oasis Dev Team Tasks Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants