Skip to content

Extend model_settings file with a loss_factor section #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sambles opened this issue Nov 11, 2024 · 1 comment
Closed

Extend model_settings file with a loss_factor section #161

sambles opened this issue Nov 11, 2024 · 1 comment
Assignees

Comments

@sambles
Copy link
Contributor

sambles commented Nov 11, 2024

Issue Description

The feature OasisLMF/OasisLMF#1558 allows for multiple PLA files to be defined on a model. But there is no place in the model_settings file to put these.

Expectation would be that it follows a similar format to event_set or event_occurrence

{
    "model_settings":{
        "lossfactor_set":{
            "name": "Lossfactor Set",
            "desc": "Lossfactor Set,
            "default": "10k",
            "options":[{
                "id": "1k",
                "desc":"1k"
            },{
                "id": "10k",
                "desc":"10k"
            }]
        },
        "event_set":{
            "name": "Event Set",
            "desc": "Event Set",
            "default": "10k",
            "options":[{
                "id": "1k",
                "desc":"1k"
            },{
                "id": "10k",
                "desc":"10k"
            }]
        },
          ...
@sambles
Copy link
Contributor Author

sambles commented Nov 22, 2024

dup of #148 closing this issue

@sambles sambles closed this as completed Nov 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Oasis Dev Team Tasks Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant