Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging - V2 input generation and losses tar should include log files for all sub-tasks #1075

Closed
sambles opened this issue Jul 4, 2024 · 2 comments · Fixed by #1103
Closed
Assignees
Labels
Enhancement Small improvement or refinement. LTS - 2.3 production
Milestone

Comments

@sambles
Copy link
Contributor

sambles commented Jul 4, 2024

Issue Description

For V1 analyses, the log files are included in the result tar files.

Do the same for V2 tar files, download all sub-task logs and put them into a log/<uuid>.txt dir.

@sambles sambles added Enhancement Small improvement or refinement. production LTS - 2.3 labels Jul 4, 2024
@sambles sambles self-assigned this Jul 4, 2024
@sambles
Copy link
Contributor Author

sambles commented Jul 17, 2024

Note: run_log_file also needs aligning between v1 and v2

carlfischerjba: v1 and v2 analysis run logs are accessible via the API but for a v2 analysis the tar.gz contains a logs subdirectory instead of containing everything at the root of the archive as is the case for v1. Makes it a bit harder to do like for like comparisons or parametrise tests to run on both versions of a model.

@carlfischerjba
Copy link
Collaborator

The <uuid>.txt file containing the combined input gen logs seems to have disappeared for V1 analyses too. We've seen this on NRMC which is currently using Oasis 2.3.5 and the worker is using Oasis 2.3.6.

@aiste-kalinauskaite aiste-kalinauskaite moved this from Todo to In Progress in Oasis Dev Team Tasks Aug 6, 2024
@sambles sambles linked a pull request Aug 14, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Oasis Dev Team Tasks Aug 16, 2024
@awsbuild awsbuild added this to the 2.3.8 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Small improvement or refinement. LTS - 2.3 production
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants