Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return of types of create 'analyses' and 'model' POST in API spec. #1076

Closed
sambles opened this issue Jul 9, 2024 · 1 comment · Fixed by #1078
Closed

Fix return of types of create 'analyses' and 'model' POST in API spec. #1076

sambles opened this issue Jul 9, 2024 · 1 comment · Fixed by #1078

Comments

@sambles
Copy link
Contributor

sambles commented Jul 9, 2024

Issue Description

The enchantment #1067 allows settings JSON to be added when creating either an /analyses/ or /model/ to support this the serializers have been split between:
"Read Only" ['AnalysisList', 'AnalsysisModelList'], and "Writeable" ['Analysis', 'AnalsysisModel']

When sending POST request create new objects the 'Writeable' objects are called which have a 'settings: ' section.

Problem: The return from this request is also Analysis or AnalsysisModel which is incorrect. It should be the read-only serializers.

Also check and fix that AnalysisModelList has its list of data file ids (like with AnalysisModel)

@sambles
Copy link
Contributor Author

sambles commented Jul 9, 2024

create an RC version for testing when ready

@sambles sambles moved this to In Progress in Oasis Dev Team Tasks Jul 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Oasis Dev Team Tasks Jul 10, 2024
@awsbuild awsbuild added this to the 2.3.7 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants