Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FillValue #70

Open
castelao opened this issue Jun 14, 2022 · 6 comments
Open

FillValue #70

castelao opened this issue Jun 14, 2022 · 6 comments
Labels
1.1 Tickets for )G 1.1 release
Milestone

Comments

@castelao
Copy link
Member

During the meeting on Jun 14 it was raised the question if FillValue should be locked, i.e. fixed value, or allow the user to define. There is an advantage to leaving it free, since it is clearly defined in the file and any software can parse it, as long as it is the same data type. Seems like we are inclined toward a free value.

Emma raised an important point that if it is a free value it would be a problem when aggregating multiple deployments. For instance, ERDDAP would take the first or the last attribute.

Since we haven't clear a path to go, we decided to move the discussion here to give us some time to think about it.

@vturpin
Copy link
Member

vturpin commented Aug 31, 2022

During our last meeting, we agree that aggregating data set together should not be our driver to define the format. I do not have strong opinion on this.
This is a benefic / risk balance I guess.

@castelao
Copy link
Member Author

castelao commented Sep 1, 2022

Well, as long as it is clear that this is a free value, clearly defined on _FillValue, we can transfer the responsibility to the aggregator to inspect and conform the aggregating elements.

My suggestion is to let it be a free field, suggesting the use of NaN for float and double.

@vturpin
Copy link
Member

vturpin commented Sep 2, 2022

I am fine with that !

@castelao
Copy link
Member Author

castelao commented Sep 3, 2022

If no one step in, I will open a new PR on the first chance.

@vturpin vturpin added the 1.0 For stuff that must be resolved before we are able to release 1.0 label Sep 22, 2022
@castelao castelao added this to the OG-1.0 milestone Sep 24, 2022
@callumrollo
Copy link
Member

I believe this was resolved in #114 @castelao can you confirm? If so, suggest we close this Issue

@justinbuck
Copy link
Collaborator

Discussion 24th April 2023 - recommended fill values are agreeable.
Fill values to be defined in OG 1.1

@justinbuck justinbuck added 1.1 Tickets for )G 1.1 release and removed 1.0 For stuff that must be resolved before we are able to release 1.0 labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.1 Tickets for )G 1.1 release
Projects
None yet
Development

No branches or pull requests

4 participants