Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: dry-run default: preserve found binaries unless --clean #2

Closed
buckleyc opened this issue Jun 19, 2024 · 3 comments
Closed

Comments

@buckleyc
Copy link

Issue: this app seems to delete found files as the default without offering the user a choice.
Suggestion: My suggestion is to refactor the code to place clean_dir() action (and possibly any signing) inside a conditional, thus having a non-destructive default, and add the --clean option, to allow the user to clean_dir() and sign the found results.

@buckleyc buckleyc changed the title feature request: --dry-run to preserve found binaries, or --purge to purge feature request: dry-run default: preserve found binaries unless --clean Jun 19, 2024
@Oct4Pie
Copy link
Owner

Oct4Pie commented Jun 21, 2024

Thanks for your input.
I assume you are referring to the python script.
May you clarify what exactly are you suggesting? You want to duplicate the app without cleaning binaries and signing?
Or you want to have control over which binaries are cleaned/signed?

@buckleyc
Copy link
Author

If you are familiar with tools such as git, rsync, or make, you may have noticed they provide an option to simulate the intended action without making any changes but properly reporting what would be modified (e.g., deleted). These tools provide -n as the short option for dry-run.
I feel that tools which could execute a destructive act (e.g., deleting system files) should have a safety valve to prevent a user from doing something they could later regret.
Even the destructive rm command provides the -i option to help newbies from hurting themselves.

@Oct4Pie
Copy link
Owner

Oct4Pie commented Jun 30, 2024

I see what you mean. You want to this feature exclusively for the python script?
This can be implemented but the reason that the script duplicates the app is exactly this. It lets the user try and test the outcome without changing the original application folder.

Therefore, running rsync on the duplicated, modified application should produce what you are looking for. How do you think this may be added as a feature in this case?

@Oct4Pie Oct4Pie closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants