From 30019b214078307115ee31a4ca28623d05e754ea Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Thu, 25 Jul 2024 19:25:21 +0300 Subject: [PATCH 1/3] fix spelling rollupCreation.ts --- scripts/rollupCreation.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/rollupCreation.ts b/scripts/rollupCreation.ts index e70b82dcb..1089874d7 100644 --- a/scripts/rollupCreation.ts +++ b/scripts/rollupCreation.ts @@ -84,7 +84,7 @@ export async function createRollup( // 0.13 ETH is enough to deploy L2 factories via retryables. Excess is refunded let feeCost = ethers.utils.parseEther('0.13') if (feeToken != ethers.constants.AddressZero) { - // in case fees are paid via fee token, then approve rollup cretor to spend required amount + // in case fees are paid via fee token, then approve rollup creator to spend required amount feeCost = await _getPrescaledAmount( ERC20__factory.connect(feeToken, signer), feeCost From b3511db506768df7f5375479bdbb96757c5a60bf Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Thu, 25 Jul 2024 19:26:09 +0300 Subject: [PATCH 2/3] fix typo AbsBridge.sol --- src/bridge/AbsBridge.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bridge/AbsBridge.sol b/src/bridge/AbsBridge.sol index bafd56f95..8c374838e 100644 --- a/src/bridge/AbsBridge.sol +++ b/src/bridge/AbsBridge.sol @@ -219,7 +219,7 @@ abstract contract AbsBridge is Initializable, DelegateCallAware, IBridge { // We set and reset active outbox around external call so activeOutbox remains valid during call // We use a low level call here since we want to bubble up whether it succeeded or failed to the caller - // rather than reverting on failure as well as allow contract and non-contract calls + // rather than reverting on failure as well as allowing contract and non-contract calls (success, returnData) = _executeLowLevelCall(to, value, data); _activeOutbox = prevOutbox; From f1fe2708a7bdb0f8ed31c4f2e369ebc18a33ff96 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Thu, 25 Jul 2024 19:26:39 +0300 Subject: [PATCH 3/3] fix AbsInbox.sol --- src/bridge/AbsInbox.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bridge/AbsInbox.sol b/src/bridge/AbsInbox.sol index 1078f0cf8..6c6996d46 100644 --- a/src/bridge/AbsInbox.sol +++ b/src/bridge/AbsInbox.sol @@ -76,7 +76,7 @@ abstract contract AbsInbox is DelegateCallAware, PausableUpgradeable, IInboxBase /// @dev this modifier checks the tx.origin instead of msg.sender for convenience (ie it allows /// allowed users to interact with the token bridge without needing the token bridge to be allowList aware). - /// this modifier is not intended to use to be used for security (since this opens the allowList to + /// this modifier is not intended to be used for security (since this opens the allowList to /// a smart contract phishing risk). modifier onlyAllowed() { // solhint-disable-next-line avoid-tx-origin