feat: onboard new sample "Policies Graph connector" #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecton
requested review from
HuihuiWu-Microsoft,
wenytang-ms,
MSFT-yiz,
KennethBWSong and
LongOddCode
as code owners
tecton
changed the title
wenytang-ms
reviewed
Oct 8, 2024
.config/samples-config-v3.json
Outdated
| "shortId": "nodejs-ts-policies", | ||
| "onboardDate": "2024-09-24", | ||
| "title": "Policies Graph connector", | ||
| "shortDescription": "This sample project uses Teams Toolkit for Visual Studio Code to simplify the process of creating a Microsoft Graph connector that ingests data from a custom API to Microsoft Graph. It provides an end to end example of creating the connector, ingesting content and refreshing the ingested content.", |
There was a problem hiding this comment.
this short description is same as full description, may be cut off the "it provides ……"?
wenytang-ms
approved these changes
Oct 8, 2024
| "shortId": "nodejs-ts-policies", | ||
| "onboardDate": "2024-09-24", | ||
| "title": "Policies Graph connector", | ||
| "shortDescription": "This sample project uses Teams Toolkit for Visual Studio Code to simplify the process of creating a Microsoft Graph connector that ingests data from a custom API to Microsoft Graph.", |
There was a problem hiding this comment.
Is shortDescription still used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: define sample type
Related sample: #1323