diff --git a/.gitignore b/.gitignore index 2421ac0..111b954 100644 --- a/.gitignore +++ b/.gitignore @@ -2,3 +2,5 @@ node_modules .tmp .sass-cache bower_components +dist/assets +dist/images diff --git a/PULL_REQUEST_REVIEW.md b/PULL_REQUEST_REVIEW.md new file mode 100644 index 0000000..9032184 --- /dev/null +++ b/PULL_REQUEST_REVIEW.md @@ -0,0 +1,309 @@ +# Code Review: PR #1 - Migration from AngularJS to Vue 3 + +**Pull Request:** [#1 - try code reviewing tools](https://github.com/OlafurTorfi/frisbski/pull/1) +**Branch:** `test` → `master` +**Status:** ✅ CI Passing +**Changes:** 66 files changed, +4507 additions, -2880 deletions + +--- + +## 📋 Summary + +This PR represents a **major architectural migration** from a legacy AngularJS application with Grunt/Bower build tooling to a modern Vue 3 single-page application (SPA) built with Vite. The migration successfully modernizes the entire tech stack while preserving the core functionality of the Frisbski website. + +### Key Changes: +- **Frontend Framework:** AngularJS → Vue 3 +- **Build Tool:** Grunt → Vite +- **Package Manager:** Bower → npm (exclusively) +- **Testing Framework:** Karma/Jasmine → Vitest +- **CI/CD:** Travis CI → GitHub Actions +- **Server:** Updated Express to v5 with ES modules + +--- + +## ✅ What Works Well + +### 1. **Clean Architecture** +- Well-structured Vue 3 components using Composition API (`