From 029e14a00769afed3d1d0d3c253db899c407a09d Mon Sep 17 00:00:00 2001 From: Jason Yundt Date: Mon, 20 Sep 2021 19:48:18 -0400 Subject: [PATCH 1/2] Remove unused SO_TARGET --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index 2550220..e2a1053 100644 --- a/Makefile +++ b/Makefile @@ -10,7 +10,6 @@ TEST_SRC=$(wildcard tests/*_tests.cpp) TESTS=$(patsubst %.cpp,%,$(TEST_SRC)) TARGET=build/isextract -SO_TARGET=$(patsubst %.a,%.so,$(TARGET)) # The Target Build all: $(TARGET) From 79f042c7a0963e3c21ea6d8dd89a397cd27687e2 Mon Sep 17 00:00:00 2001 From: Jason Yundt Date: Mon, 20 Sep 2021 20:03:32 -0400 Subject: [PATCH 2/2] Rename TARGET variable I thought that it was confusing to have the variable be named "TARGET" since target can also mean something else when talking about Makefiles. --- Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index e2a1053..fe9f013 100644 --- a/Makefile +++ b/Makefile @@ -9,10 +9,10 @@ OBJECTS=$(patsubst %.cpp,%.o,$(SOURCES)) TEST_SRC=$(wildcard tests/*_tests.cpp) TESTS=$(patsubst %.cpp,%,$(TEST_SRC)) -TARGET=build/isextract +EXECUTABLE=build/isextract # The Target Build -all: $(TARGET) +all: $(EXECUTABLE) dev: CXXFLAGS=-g -Wall -Wexta $(OPTFLAGS) dev: all @@ -22,8 +22,8 @@ win32: CXX=i586-mingw32msvc-g++ -$(TARGET): build $(OBJECTS) - $(CC) $(OBJECTS) -o $(TARGET) +$(EXECUTABLE): build $(OBJECTS) + $(CC) $(OBJECTS) -o $(EXECUTABLE) build: @mkdir -p build @@ -39,7 +39,7 @@ clean: # The Install install: all install -d $(DESTDIR)/$(PREFIX)/lib/ - install $(TARGET) $(DESTDIR)/$(PREFIX)/lib/ + install $(EXECUTABLE) $(DESTDIR)/$(PREFIX)/lib/ # The Checker BADFUNCS='[^_.>a-zA-Z0-9](str(n?cpy|n?cat|xfrm|n?dup|str|pbrk|tok|_)|stpn?cpy|a?sn?printf|byte_)'