Make BooleanOr class instead of struct to fix ignore null value when serializing

Author: bjorkstromm

src/Protocol/Models/BooleanOr.cs

@@ -1,6 +1,6 @@
 namespace OmniSharp.Extensions.LanguageServer.Protocol.Models
 {
-    public struct BooleanOr<T>
+    public class BooleanOr<T>
     {
         private T _value;
         private bool? _bool;

src/Protocol/Serialization/Converters/BooleanOrConverter.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Reflection;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
@@ -29,7 +29,7 @@ private static void WriteJsonGeneric<T>(JsonWriter writer, BooleanOr<T> value, J
                 return;
             }
 
-            if (value.IsBool && value.Bool)
+            if (value.IsBool)
             {
                 new JValue(value.Bool).WriteTo(writer);
                 return;
@@ -57,11 +57,11 @@ private static BooleanOr<T> ReadJsonGeneric<T>(JsonReader reader, object existin
                 return new BooleanOr<T>(JObject.Load(reader).ToObject<T>(serializer));
             }
 
-            return new BooleanOr<T>();
+            return new BooleanOr<T>(default(T));
         }
 
         public override bool CanRead => true;
 
         public override bool CanConvert(Type objectType) => objectType.GetTypeInfo().IsGenericType && objectType.GetTypeInfo().GetGenericTypeDefinition() == typeof(BooleanOr<>);
     }
-}
+}

test/Lsp.Tests/Capabilities/Server/ServerCapabilitiesTests.cs

@@ -59,6 +59,10 @@ public void SimpleTest(string expected)
                     WillSaveWaitUntil = true
                 }),
                 WorkspaceSymbolProvider = true,
+                ColorProvider = true,
+                FoldingRangeProvider = true,
+                ImplementationProvider = true,
+                TypeDefinitionProvider = true
             };
             var result = Fixture.SerializeObject(model);
 
@@ -67,5 +71,18 @@ public void SimpleTest(string expected)
             var deresult = new Serializer(ClientVersion.Lsp3).DeserializeObject<ServerCapabilities>(expected);
             deresult.Should().BeEquivalentTo(model);
         }
+
+        [Theory, JsonFixture]
+        public void Optional(string expected)
+        {
+            var model = new ServerCapabilities();
+
+            var result = Fixture.SerializeObject(model);
+
+            result.Should().Be(expected);
+
+            var deresult = new Serializer(ClientVersion.Lsp3).DeserializeObject<ServerCapabilities>(expected);
+            deresult.Should().BeEquivalentTo(model);
+        }
     }
 }

test/Lsp.Tests/Capabilities/Server/ServerCapabilitiesTests_$Optional.json

@@ -0,0 +1,11 @@
+{
+    "hoverProvider": false,
+    "definitionProvider": false,
+    "referencesProvider": false,
+    "documentHighlightProvider": false,
+    "documentSymbolProvider": false,
+    "workspaceSymbolProvider": false,
+    "documentFormattingProvider": false,
+    "documentRangeFormattingProvider": false,
+    "experimental": {}
+}

test/Lsp.Tests/Capabilities/Server/ServerCapabilitiesTests_$SimpleTest.json

@@ -54,8 +54,8 @@
     "experimental": {
         "abc": "123"
     },
-    "typeDefinitionProvider": null,
-    "implementationProvider": null,
-    "colorProvider": null,
-    "foldingRangeProvider": null
+    "typeDefinitionProvider": true,
+    "implementationProvider": true,
+    "colorProvider": true,
+    "foldingRangeProvider": true
 }

test/Lsp.Tests/Models/InitializeResultTests_$SimpleTest.json

@@ -54,10 +54,6 @@
         },
         "experimental": {
             "abc": "123"
-        },
-        "typeDefinitionProvider": null,
-        "implementationProvider": null,
-        "colorProvider": null,
-        "foldingRangeProvider": null
+        }
     }
 }