Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show bookmarks when location unavailable (fixes: #680) #789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flash1729
Copy link

Fixes #680

When location services are disabled and bookmarks are sorted by distance:

  • Previously: No bookmarks were shown with a "Location Unavailable" message (see screenshot below)
  • Now: Falls back to showing bookmarks sorted by group.

Changes made :

  1. Changed listItemsSortedByDistance() to fall back to group sorting when no location
  2. Modified items(for:) to automatically fall back to group sorting when location is unavailable
  3. Updated emptyData(for:) to only show empty state for actual empty bookmarks

Before (Location Unavailable):
image

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2025

CLA assistant check
All committers have signed the CLA.

@flash1729
Copy link
Author

@aaronbrethorst can you please review this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants