Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use revision control #18

Open
TediusTimmy opened this issue Oct 8, 2019 · 1 comment
Open

Actually use revision control #18

TediusTimmy opened this issue Oct 8, 2019 · 1 comment

Comments

@TediusTimmy
Copy link

This will be a polemic from a pompous arse, do forgive me. I do like your videos, however...
While I realize that I am perfectly capable of diffing two of the directories that you've made (kdiff3 being my tool of choice), GitHub includes tools that allow anyone to view the differences between two commits and see what has changed. I just feel that it would be more useful to teach people how to use (git and a site like GitHub) effectively than to have them diff things themselves. If you want to go back in time, you can checkout a specific revision.

Just my unwanted two cents.

PS. Did you know that this is a thing: https://jsnes.org/

@TediusTimmy
Copy link
Author

TediusTimmy commented Oct 8, 2019

For example, see my fork https://github.com/TediusTimmy/olcNES .

Something that we can see from this: between videos 3 and 4, you added mappers 2, 3, and 66. And for the code you commit for video 5, you forgot to re-comment out these mappers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant