Persistence limits are not updated when limits are updated

[jalbiero]

I don't know if this is a bug or an intended design:

Supose I set the limits with:

$ sudo batctl set --preset plugged-in
Applying preset "Plugged In" (adapted: start=70, stop=80)
Thresholds set: start=70% stop=80% on BAT0

Then enable persistence:

$ sudo batctl persist enable
Persistence enabled: start=70% stop=80% on BAT0
Systemd services installed (boot + resume).

Later, another day, I change the limits:

$ sudo batctl set --preset balanced
Applying preset "Balanced" (adapted: start=40, stop=80)
Thresholds set: start=40% stop=80% on BAT0

If I reboot or suspend/wakeup the PC, I will get the limits that I set when I enabled the persistance, not the latest ones:

$ sudo batctl status
Backend: ThinkPad

BAT0 (SMP 5B11M90056)
  Status:     Not charging
  Capacity:   78%
  Health:     103.4%
  Cycles:     15
  Energy:     46.0 / 59.0 Wh (design: 57.0 Wh)
  Thresholds: start=70% stop=80%
  Behaviour:  auto (available: auto, inhibit-charge, force-discharge)

Persistence:  boot=true  resume=true

IMHO this is confusing, because I already updated the limits. I think the correct behavior is the following:

If I set a new limits and the persistence is enabled, then the persistence limits (in /etc/batctl.conf) should be updated with the new values

The workaround is to remember to always enable the persistence (even if it already enabled) every time the new limits are changed, something like the following:

$ sudo batctl set <new values or persistence profile>
$ sudo batctl persist enable